This is an archive of the discontinued LLVM Phabricator instance.

Differential D99536

[WebAssembly] Fix i8x16.popcnt opcode
ClosedPublic

Authored by tlively on Mar 29 2021, 1:23 PM.

Details

Reviewers
aheejin
dschuff
Commits
rGa1b8b0739a34: [WebAssembly] Fix i8x16.popcnt opcode
Summary

When I updated the SIMD opcodes in f5764a8654e3, I accidentally missed updating
i8x16.popcnt. This patch fixes the omission.

Diff Detail

Event Timeline

tlively created this revision.Mar 29 2021, 1:23 PM
Herald added subscribers: wingo, ecnelises, sunfish and 3 others. · View Herald TranscriptMar 29 2021, 1:23 PM
tlively requested review of this revision.Mar 29 2021, 1:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2021, 1:23 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B96186: Diff 333971.Mar 29 2021, 1:53 PM
nemequ added a subscriber: nemequ.Mar 29 2021, 2:08 PM
dschuff accepted this revision.Mar 29 2021, 3:37 PM
This revision is now accepted and ready to land.Mar 29 2021, 3:37 PM
Closed by commit rGa1b8b0739a34: [WebAssembly] Fix i8x16.popcnt opcode (authored by tlively). · Explain WhyMar 29 2021, 5:23 PM
This revision was automatically updated to reflect the committed changes.
tlively added a commit: rGa1b8b0739a34: [WebAssembly] Fix i8x16.popcnt opcode.

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
2 lines
test/
MC/
WebAssembly/
3 lines

Diff 334019

llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td

Show First 20 Lines • Show All 826 Lines • ▼ Show 20 Lines
// Any lane true: any_true // Any lane true: any_true
defm ANYTRUE : SIMDReduce<int_wasm_anytrue, "any_true", 98>; defm ANYTRUE : SIMDReduce<int_wasm_anytrue, "any_true", 98>;
// All lanes true: all_true // All lanes true: all_true
defm ALLTRUE : SIMDReduce<int_wasm_alltrue, "all_true", 99>; defm ALLTRUE : SIMDReduce<int_wasm_alltrue, "all_true", 99>;
// Population count: popcnt // Population count: popcnt
defm POPCNT : SIMDUnary<I8x16, int_wasm_popcnt, "popcnt", 124>; defm POPCNT : SIMDUnary<I8x16, int_wasm_popcnt, "popcnt", 0x62>;
// Reductions already return 0 or 1, so and 1, setne 0, and seteq 1 // Reductions already return 0 or 1, so and 1, setne 0, and seteq 1
// can be folded out // can be folded out
foreach reduction = foreach reduction =
[["int_wasm_anytrue", "ANYTRUE"], ["int_wasm_alltrue", "ALLTRUE"]] in [["int_wasm_anytrue", "ANYTRUE"], ["int_wasm_alltrue", "ALLTRUE"]] in
foreach vec = IntVecs in { foreach vec = IntVecs in {
defvar intrinsic = !cast<Intrinsic>(reduction[0]); defvar intrinsic = !cast<Intrinsic>(reduction[0]);
defvar inst = !cast<NI>(reduction[1]#"_"#vec); defvar inst = !cast<NI>(reduction[1]#"_"#vec);
▲ Show 20 Lines • Show All 419 Lines • Show Last 20 Lines

llvm/test/MC/WebAssembly/simd-encodings.s

Show First 20 Lines • Show All 318 Lines • ▼ Show 20 Linesmain:
f64x2.promote_low_f32x4 f64x2.promote_low_f32x4
# CHECK: i8x16.abs # encoding: [0xfd,0x60] # CHECK: i8x16.abs # encoding: [0xfd,0x60]
i8x16.abs i8x16.abs
# CHECK: i8x16.neg # encoding: [0xfd,0x61] # CHECK: i8x16.neg # encoding: [0xfd,0x61]
i8x16.neg i8x16.neg
# TODO: i8x16.popcnt # encoding: [0xfd,0x62] # CHECK: i8x16.popcnt # encoding: [0xfd,0x62]
i8x16.popcnt
# CHECK: i8x16.all_true # encoding: [0xfd,0x63] # CHECK: i8x16.all_true # encoding: [0xfd,0x63]
i8x16.all_true i8x16.all_true
# CHECK: i8x16.bitmask # encoding: [0xfd,0x64] # CHECK: i8x16.bitmask # encoding: [0xfd,0x64]
i8x16.bitmask i8x16.bitmask
# CHECK: i8x16.narrow_i16x8_s # encoding: [0xfd,0x65] # CHECK: i8x16.narrow_i16x8_s # encoding: [0xfd,0x65]
▲ Show 20 Lines • Show All 438 Lines • Show Last 20 Lines