Page MenuHomePhabricator

[NFC][LoopUnswitch] Move hasPartialIVCondition to LoopUtils
ClosedPublic

Authored by jaykang10 on Mon, Mar 29, 2:17 AM.

Details

Summary

In LoopUnswitch, move shared code to LoopUtils. It is related to https://reviews.llvm.org/D99354

Diff Detail

Event Timeline

jaykang10 created this revision.Mon, Mar 29, 2:17 AM
jaykang10 requested review of this revision.Mon, Mar 29, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Mar 29, 2:17 AM
lebedev.ri accepted this revision.Mon, Mar 29, 2:23 AM
lebedev.ri retitled this revision from [LoopUnswitch] Move hasPartialIVCondition to LoopUtils to [NFC][LoopUnswitch] Move hasPartialIVCondition to LoopUtils.

LGTM

This revision is now accepted and ready to land.Mon, Mar 29, 2:23 AM
This revision was landed with ongoing or failed builds.Mon, Mar 29, 2:44 AM
This revision was automatically updated to reflect the committed changes.
fhahn added inline comments.Mon, Mar 29, 3:08 AM
llvm/include/llvm/Transforms/Utils/LoopUtils.h
516

L, MSSA and AA are all needed. Can we pass them by reference?

jaykang10 added inline comments.Mon, Mar 29, 3:29 AM
llvm/include/llvm/Transforms/Utils/LoopUtils.h
516

Ah, let me change it on https://reviews.llvm.org/D99354. Is it ok?

SjoerdMeijer added inline comments.
llvm/include/llvm/Transforms/Utils/LoopUtils.h
516

Looks like a very small change to me. If you're confident, just go ahead and commit this without review. If you want to a second opinion, we can always look at it in a review.

jaykang10 added inline comments.Thu, Apr 8, 5:15 AM
llvm/include/llvm/Transforms/Utils/LoopUtils.h
516

It has been merged to upstream. commit cfe87d4eddfccff4b6fb09156d5645790240a8e8