Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D99404

[Utils][Emacs] Improve syntax highlight
ClosedPublic
Actions

Authored by condy on Mar 26 2021, 2:39 AM.

Details

Reviewers
MaskRay
zsrkmyn
condy
Commits
rGd332bbee45b5: [Utils][Emacs] Improve syntax highlight

Diff Detail

Event Timeline

condy created this revision.Mar 26 2021, 2:39 AM
Herald added a subscriber: jfb. · View Herald TranscriptMar 26 2021, 2:39 AM
condy requested review of this revision.Mar 26 2021, 2:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 2:39 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
condy added a comment.EditedMar 26 2021, 2:40 AM
  1. Drop Emacs 23 support, since it's 10 years old.
  2. Highlight more keywords
condy added a reviewer: MaskRay.Mar 26 2021, 2:41 AM
condy added reviewers: zsrkmyn, condy.Mar 26 2021, 2:47 AM
Harbormaster completed remote builds in B95849: Diff 333515.Mar 26 2021, 3:36 AM
condy updated this revision to Diff 333836.Mar 29 2021, 6:16 AM

Update

Harbormaster completed remote builds in B96096: Diff 333836.Mar 29 2021, 6:51 AM
MaskRay accepted this revision.Mar 29 2021, 3:35 PM

Looks great!

This revision is now accepted and ready to land.Mar 29 2021, 3:35 PM
MaskRay added a comment.Mar 29 2021, 3:36 PM

Perhaps cross check vscode extensions.

condy added a comment.Mar 30 2021, 12:10 AM
In D99404#2657112, @MaskRay wrote:

Perhaps cross check vscode extensions.

Thanks for pointing out.

Closed by commit rGd332bbee45b5: [Utils][Emacs] Improve syntax highlight (authored by condy, committed by MaskRay). · Explain WhyMar 30 2021, 7:32 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGd332bbee45b5: [Utils][Emacs] Improve syntax highlight.

Revision Contents
Changeset List

PathSize
llvm/
utils/
emacs/
40 lines

Diff 334325

View Options

llvm/utils/emacs/llvm-mode.el

Loading...