Page MenuHomePhabricator

condy (Zhiwei Chen)
User

Projects

User Details

User Since
Dec 31 2020, 2:03 AM (24 w, 3 d)

Recent Activity

May 20 2021

condy added a comment to D102592: [sanitizer] Caught global buffer underflow for first variable.

I think it is too hit-and-miss to add even under a flag. It's just not the right approach - but I also don't know what the right approach would be.

Perhaps adding a small left redzone for all globals and reducing the right redzone to keep the total size under control? This way when most globals are instrumented we get approximately the same amount of redzone between any 2 of them, but also a little on the left of the first one.

May 20 2021, 12:11 AM · Restricted Project, Restricted Project

May 19 2021

condy added inline comments to D102469: [sanitizer] Reduce redzone size for small size global objects.
May 19 2021, 6:48 PM · Restricted Project, Restricted Project
condy updated the diff for D102469: [sanitizer] Reduce redzone size for small size global objects.

Apply optimization when SizeInBytes <= MinRZ/2

May 19 2021, 6:44 PM · Restricted Project, Restricted Project

May 18 2021

condy added a comment to D102592: [sanitizer] Caught global buffer underflow for first variable.

You are adding a new global to every translation unit.

  • Private linkage would not allow them to be merged, this can have significant binary size and RAM overhead.
May 18 2021, 1:30 AM · Restricted Project, Restricted Project
condy added a comment to D102592: [sanitizer] Caught global buffer underflow for first variable.

Would you mind to add compiler-rt/test/asan which triggers this one?

May 18 2021, 12:50 AM · Restricted Project, Restricted Project

May 17 2021

condy added inline comments to D102469: [sanitizer] Reduce redzone size for small size global objects.
May 17 2021, 11:33 PM · Restricted Project, Restricted Project
condy updated the diff for D102469: [sanitizer] Reduce redzone size for small size global objects.

Update as suggected

May 17 2021, 11:32 PM · Restricted Project, Restricted Project
condy added reviewers for D102592: [sanitizer] Caught global buffer underflow for first variable: eugenis, vitalybuka.
May 17 2021, 2:29 AM · Restricted Project, Restricted Project
condy updated the diff for D102592: [sanitizer] Caught global buffer underflow for first variable.

Fix typos

May 17 2021, 1:24 AM · Restricted Project, Restricted Project
condy updated the diff for D102592: [sanitizer] Caught global buffer underflow for first variable.

Fix all tests

May 17 2021, 1:21 AM · Restricted Project, Restricted Project
condy updated the diff for D102592: [sanitizer] Caught global buffer underflow for first variable.

Fix some tests

May 17 2021, 12:52 AM · Restricted Project, Restricted Project
condy updated the diff for D102592: [sanitizer] Caught global buffer underflow for first variable.

Fix some tests

May 17 2021, 12:21 AM · Restricted Project, Restricted Project
condy updated the summary of D102592: [sanitizer] Caught global buffer underflow for first variable.
May 17 2021, 12:20 AM · Restricted Project, Restricted Project

May 16 2021

condy updated the summary of D102592: [sanitizer] Caught global buffer underflow for first variable.
May 16 2021, 8:45 PM · Restricted Project, Restricted Project
condy requested review of D102592: [sanitizer] Caught global buffer underflow for first variable.
May 16 2021, 8:44 PM · Restricted Project, Restricted Project

May 14 2021

condy updated the diff for D102469: [sanitizer] Reduce redzone size for small size global objects.

Fix clang/codegen tests

May 14 2021, 3:44 AM · Restricted Project, Restricted Project
condy updated the diff for D102469: [sanitizer] Reduce redzone size for small size global objects.

Fix all tests

May 14 2021, 1:04 AM · Restricted Project, Restricted Project
condy updated the diff for D102469: [sanitizer] Reduce redzone size for small size global objects.

Fix tests

May 14 2021, 12:42 AM · Restricted Project, Restricted Project
condy added a reviewer for D102469: [sanitizer] Reduce redzone size for small size global objects: Restricted Project.
May 14 2021, 12:19 AM · Restricted Project, Restricted Project
condy updated the summary of D102469: [sanitizer] Reduce redzone size for small size global objects.
May 14 2021, 12:13 AM · Restricted Project, Restricted Project
condy added reviewers for D102469: [sanitizer] Reduce redzone size for small size global objects: zsrkmyn, MaskRay.
May 14 2021, 12:10 AM · Restricted Project, Restricted Project
condy requested review of D102469: [sanitizer] Reduce redzone size for small size global objects.
May 14 2021, 12:06 AM · Restricted Project, Restricted Project

Mar 30 2021

condy added a comment to D99404: [Utils][Emacs] Improve syntax highlight.

Perhaps cross check vscode extensions.

Mar 30 2021, 12:10 AM · Restricted Project

Mar 29 2021

condy updated the diff for D99404: [Utils][Emacs] Improve syntax highlight.

Update

Mar 29 2021, 6:16 AM · Restricted Project

Mar 26 2021

condy added reviewers for D99404: [Utils][Emacs] Improve syntax highlight: zsrkmyn, condy.
Mar 26 2021, 2:47 AM · Restricted Project
condy added a reviewer for D99404: [Utils][Emacs] Improve syntax highlight: MaskRay.
Mar 26 2021, 2:41 AM · Restricted Project
condy added a comment to D99404: [Utils][Emacs] Improve syntax highlight.
  1. Drop Emacs 23 support, since it's 10 years old.
  2. Highlight more keywords
Mar 26 2021, 2:40 AM · Restricted Project
condy requested review of D99404: [Utils][Emacs] Improve syntax highlight.
Mar 26 2021, 2:39 AM · Restricted Project

Mar 18 2021

condy added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Since this patch already changed output of many test cases, do we still need a test case specifically for this patch?

You'd better add some mir tests to demonstrate the idea, w/o -g.

Mar 18 2021, 1:05 AM · Restricted Project

Mar 16 2021

condy updated the diff for D98401: [CodeGen] Fix backward copy propagation with -g.

Move test to machine-copy-props.mir

Mar 16 2021, 1:30 AM · Restricted Project

Mar 15 2021

condy added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Please do move https://reviews.llvm.org/D98401 regression test to this patch set

Mar 15 2021, 11:18 PM · Restricted Project
condy abandoned D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 15 2021, 11:16 PM · Restricted Project
condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

https://reviews.llvm.org/D98659 could supersede this

Mar 15 2021, 11:15 PM · Restricted Project
condy updated the diff for D98401: [CodeGen] Fix backward copy propagation with -g.

Update test

Mar 15 2021, 1:52 AM · Restricted Project
condy updated the diff for D98401: [CodeGen] Fix backward copy propagation with -g.

CHECK-NEXT directive should be used

Mar 15 2021, 1:29 AM · Restricted Project
condy added inline comments to D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 15 2021, 1:27 AM · Restricted Project

Mar 12 2021

condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

The debuginfo should be udpate. It will be implemented in the next patch update.

Mar 12 2021, 4:13 AM · Restricted Project
condy updated the diff for D98401: [CodeGen] Fix backward copy propagation with -g.

Add a regression test

Mar 12 2021, 4:10 AM · Restricted Project
condy abandoned D98490: [CodeGen] Fix backward copy propagation with -g.

。。。

Mar 12 2021, 4:08 AM · Restricted Project
condy requested review of D98490: [CodeGen] Fix backward copy propagation with -g.
Mar 12 2021, 4:08 AM · Restricted Project
condy abandoned D98489: [CodeGen] Fix backward copy propagation with -g.

Sorry

Mar 12 2021, 4:06 AM · Restricted Project
condy requested review of D98489: [CodeGen] Fix backward copy propagation with -g.
Mar 12 2021, 4:05 AM · Restricted Project
condy added inline comments to D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 12 2021, 2:54 AM · Restricted Project
condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

You can look at some of the existing tests for machine-cp as inspiration (grep for machine-cp in llvm/test/Codegen) ,e.g. see https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/machine-cp-clobbers.mir

For more background about Machine IR & using it for testing, please take a look at https://llvm.org/docs/MIRLangRef.html#mir-testing-guide

Mar 12 2021, 1:55 AM · Restricted Project

Mar 11 2021

condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

Because you replaced $rbp with $rbx, surely you would have to replace it everywhere. Removing the DBG_VALUE is potential information loss.

Mar 11 2021, 3:58 AM · Restricted Project
condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.
renamable $rbx = nuw LEA64r %stack.5.agg.tmp.i, 1, $noreg, 8, $noreg
DBG_VALUE $rbp, $noreg, !"this", !DIExpression(), debug-location !293; hot.cpp:0 @[ hot.cpp:84:39 @[ hot.cpp:108:11 ] ] line no:0

Shouldn't the $rbp in DBG_VALUE be updated as well?

Mar 11 2021, 3:46 AM · Restricted Project
condy added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.

please add a unit test

Mar 11 2021, 2:28 AM · Restricted Project
condy updated the summary of D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 11 2021, 2:25 AM · Restricted Project
condy updated the summary of D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 11 2021, 2:10 AM · Restricted Project
condy requested review of D98401: [CodeGen] Fix backward copy propagation with -g.
Mar 11 2021, 2:04 AM · Restricted Project

Jan 25 2021

condy added a member for debug-info: condy.
Jan 25 2021, 4:40 AM

Jan 17 2021

condy added a comment to D90448: [clang] Add type check for explicit instantiation of static data members.

The tests failed though

Jan 17 2021, 6:52 PM · Restricted Project