This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][hwasan] Add C++17 new/delete operators with alignment
ClosedPublic

Authored by leonardchan on Mar 25 2021, 12:24 PM.

Details

Summary

Found that these were missing when attempting to use hwasan on Fuchsia, which uses these C++17 constructs.

Diff Detail

Event Timeline

leonardchan created this revision.Mar 25 2021, 12:24 PM
leonardchan requested review of this revision.Mar 25 2021, 12:24 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 25 2021, 12:24 PM
phosek accepted this revision.Apr 8 2021, 2:19 PM

LGTM but you should wait a bit for @pcc or @eugenis to have a chance to to review this as well.

This revision is now accepted and ready to land.Apr 8 2021, 2:19 PM
eugenis accepted this revision.Apr 8 2021, 2:43 PM

LGTM

compiler-rt/lib/hwasan/hwasan_new_delete.cpp
104

missing space before NOEXCEPT?

This revision was landed with ongoing or failed builds.Apr 8 2021, 3:45 PM
This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.