This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Compare elements directly rather than creating pair first
ClosedPublic

Authored by jpienaar on Mar 24 2021, 2:23 PM.

Details

Summary

This avoided some conversion overhead on a model in TypeUniquer.

Diff Detail

Event Timeline

jpienaar created this revision.Mar 24 2021, 2:23 PM
jpienaar requested review of this revision.Mar 24 2021, 2:23 PM
rriddle accepted this revision.Mar 24 2021, 2:28 PM

Thanks!

Can you clarify in the description that the conversion is from ArrayRef -> TypeRange? The description is a little difficult to parse right now.

This revision is now accepted and ready to land.Mar 24 2021, 2:28 PM
This revision was landed with ongoing or failed builds.Mar 24 2021, 2:39 PM
This revision was automatically updated to reflect the committed changes.