This is an archive of the discontinued LLVM Phabricator instance.

Differential D99253

[InstCombine]Generalise regression tests for sve
ClosedPublic

Authored by nasherm on Mar 24 2021, 4:01 AM.

Details

Reviewers
lebedev.ri
sdesmalen
Commits
rGb723aa2a5ab2: [InstCombine]Generalise regression tests for sve
Summary

The tests, test/Transforms/InstCombine/AArch64/sve-*,
have been shown to not be AArch64 specific. These tests
have been renamed and moved to reflect this.

Diff Detail

Event Timeline

nasherm created this revision.Mar 24 2021, 4:01 AM
Herald added subscribers: kristof.beyls, tschuett. · View Herald TranscriptMar 24 2021, 4:01 AM
nasherm requested review of this revision.Mar 24 2021, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 4:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lebedev.ri added a subscriber: lebedev.ri.Mar 24 2021, 4:02 AM

Thank you!

nasherm added a reviewer: lebedev.ri.Mar 24 2021, 4:02 AM
Harbormaster completed remote builds in B95453: Diff 332934.Mar 24 2021, 9:08 AM
sdesmalen accepted this revision.Mar 25 2021, 10:33 AM
sdesmalen added a subscriber: sdesmalen.

LGTM

This revision is now accepted and ready to land.Mar 25 2021, 10:33 AM
Closed by commit rGb723aa2a5ab2: [InstCombine]Generalise regression tests for sve (authored by nasherm). · Explain WhyMar 26 2021, 5:05 AM
This revision was automatically updated to reflect the committed changes.
nasherm added a commit: rGb723aa2a5ab2: [InstCombine]Generalise regression tests for sve.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
AArch64/
scalable-bitcast-inseltpoison.ll/
AArch64/
sve-bitcast-inseltpoison.ll
2 lines
scalable-bitcast.ll/
AArch64/
sve-bitcast.ll
2 lines
scalable-cast-of-alloc.ll/
AArch64/
sve-cast-of-alloc.ll
2 lines
scalable-const-fp-splat.ll/
AArch64/
sve-const-fp-splat.ll
2 lines
scalable-trunc.ll/
AArch64/
sve-trunc.ll
2 lines

Diff 333539

llvm/test/Transforms/InstCombine/AArch64/sve-bitcast-inseltpoison.ll

  • This file was moved to llvm/test/Transforms/InstCombine/scalable-bitcast-inseltpoison.ll.

llvm/test/Transforms/InstCombine/AArch64/sve-bitcast.ll

  • This file was moved to llvm/test/Transforms/InstCombine/scalable-bitcast.ll.

llvm/test/Transforms/InstCombine/AArch64/sve-cast-of-alloc.ll

  • This file was moved to llvm/test/Transforms/InstCombine/scalable-cast-of-alloc.ll.

llvm/test/Transforms/InstCombine/AArch64/sve-const-fp-splat.ll

  • This file was moved to llvm/test/Transforms/InstCombine/scalable-const-fp-splat.ll.

llvm/test/Transforms/InstCombine/AArch64/sve-trunc.ll

  • This file was moved to llvm/test/Transforms/InstCombine/scalable-trunc.ll.

llvm/test/Transforms/InstCombine/scalable-bitcast-inseltpoison.ll

  • This file was moved from llvm/test/Transforms/InstCombine/AArch64/sve-bitcast-inseltpoison.ll.
; RUN: opt -instcombine -mtriple=aarch64-linux-gnu -mattr=+sve -S < %s | FileCheck %s ; RUN: opt -instcombine -S < %s | FileCheck %s
; We shouldn't fold bitcast(insert <vscale x 1 x iX> .., iX %val, i32 0) ; We shouldn't fold bitcast(insert <vscale x 1 x iX> .., iX %val, i32 0)
; into bitcast(iX %val) for scalable vectors. ; into bitcast(iX %val) for scalable vectors.
define <vscale x 2 x i8> @bitcast_of_insert_i8_i16(i16 %val) #0 { define <vscale x 2 x i8> @bitcast_of_insert_i8_i16(i16 %val) #0 {
; CHECK-LABEL: @bitcast_of_insert_i8_i16( ; CHECK-LABEL: @bitcast_of_insert_i8_i16(
; CHECK-NOT: bitcast i16 %val to <vscale x 2 x i8> ; CHECK-NOT: bitcast i16 %val to <vscale x 2 x i8>
; CHECK: bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8> ; CHECK: bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8>
entry: entry:
%op2 = insertelement <vscale x 1 x i16> poison, i16 %val, i32 0 %op2 = insertelement <vscale x 1 x i16> poison, i16 %val, i32 0
%0 = bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8> %0 = bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8>
ret <vscale x 2 x i8> %0 ret <vscale x 2 x i8> %0
} }

llvm/test/Transforms/InstCombine/scalable-bitcast.ll

  • This file was moved from llvm/test/Transforms/InstCombine/AArch64/sve-bitcast.ll.
; RUN: opt -instcombine -mtriple=aarch64-linux-gnu -mattr=+sve -S < %s | FileCheck %s ; RUN: opt -instcombine -S < %s | FileCheck %s
; We shouldn't fold bitcast(insert <vscale x 1 x iX> .., iX %val, i32 0) ; We shouldn't fold bitcast(insert <vscale x 1 x iX> .., iX %val, i32 0)
; into bitcast(iX %val) for scalable vectors. ; into bitcast(iX %val) for scalable vectors.
define <vscale x 2 x i8> @bitcast_of_insert_i8_i16(i16 %val) #0 { define <vscale x 2 x i8> @bitcast_of_insert_i8_i16(i16 %val) #0 {
; CHECK-LABEL: @bitcast_of_insert_i8_i16( ; CHECK-LABEL: @bitcast_of_insert_i8_i16(
; CHECK-NOT: bitcast i16 %val to <vscale x 2 x i8> ; CHECK-NOT: bitcast i16 %val to <vscale x 2 x i8>
; CHECK: bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8> ; CHECK: bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8>
entry: entry:
%op2 = insertelement <vscale x 1 x i16> undef, i16 %val, i32 0 %op2 = insertelement <vscale x 1 x i16> undef, i16 %val, i32 0
%0 = bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8> %0 = bitcast <vscale x 1 x i16> %op2 to <vscale x 2 x i8>
ret <vscale x 2 x i8> %0 ret <vscale x 2 x i8> %0
} }

llvm/test/Transforms/InstCombine/scalable-cast-of-alloc.ll

  • This file was moved from llvm/test/Transforms/InstCombine/AArch64/sve-cast-of-alloc.ll.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -instcombine -mtriple aarch64-linux-gnu -mattr=+sve -S < %s 2>%t | FileCheck %s ; RUN: opt -instcombine -S < %s 2>%t | FileCheck %s
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t ; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it. ; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it.
; WARN-NOT: warning ; WARN-NOT: warning
define void @fixed_array16i32_to_scalable4i32(<vscale x 4 x i32>* %out) { define void @fixed_array16i32_to_scalable4i32(<vscale x 4 x i32>* %out) {
; CHECK-LABEL: @fixed_array16i32_to_scalable4i32( ; CHECK-LABEL: @fixed_array16i32_to_scalable4i32(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines

llvm/test/Transforms/InstCombine/scalable-const-fp-splat.ll

  • This file was moved from llvm/test/Transforms/InstCombine/AArch64/sve-const-fp-splat.ll.
; RUN: opt -instcombine -mtriple aarch64-linux-gnu -mattr=+sve -S -o - < %s 2>%t | FileCheck %s ; RUN: opt -instcombine -S -o - < %s 2>%t | FileCheck %s
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t ; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it. ; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it.
; WARN-NOT: warning ; WARN-NOT: warning
define <vscale x 2 x float> @shrink_splat_scalable_extend(<vscale x 2 x float> %a) { define <vscale x 2 x float> @shrink_splat_scalable_extend(<vscale x 2 x float> %a) {
; CHECK-LABEL: @shrink_splat_scalable_extend ; CHECK-LABEL: @shrink_splat_scalable_extend
; CHECK-NEXT: %[[FADD:.*]] = fadd <vscale x 2 x float> %a, shufflevector (<vscale x 2 x float> insertelement (<vscale x 2 x float> undef, float -1.000000e+00, i32 0), <vscale x 2 x float> undef, <vscale x 2 x i32> zeroinitializer) ; CHECK-NEXT: %[[FADD:.*]] = fadd <vscale x 2 x float> %a, shufflevector (<vscale x 2 x float> insertelement (<vscale x 2 x float> undef, float -1.000000e+00, i32 0), <vscale x 2 x float> undef, <vscale x 2 x i32> zeroinitializer)
; CHECK-NEXT: ret <vscale x 2 x float> %[[FADD]] ; CHECK-NEXT: ret <vscale x 2 x float> %[[FADD]]
%1 = shufflevector <vscale x 2 x float> insertelement (<vscale x 2 x float> undef, float -1.000000e+00, i32 0), <vscale x 2 x float> undef, <vscale x 2 x i32> zeroinitializer %1 = shufflevector <vscale x 2 x float> insertelement (<vscale x 2 x float> undef, float -1.000000e+00, i32 0), <vscale x 2 x float> undef, <vscale x 2 x i32> zeroinitializer
%2 = fpext <vscale x 2 x float> %a to <vscale x 2 x double> %2 = fpext <vscale x 2 x float> %a to <vscale x 2 x double>
%3 = fpext <vscale x 2 x float> %1 to <vscale x 2 x double> %3 = fpext <vscale x 2 x float> %1 to <vscale x 2 x double>
%4 = fadd <vscale x 2 x double> %2, %3 %4 = fadd <vscale x 2 x double> %2, %3
%5 = fptrunc <vscale x 2 x double> %4 to <vscale x 2 x float> %5 = fptrunc <vscale x 2 x double> %4 to <vscale x 2 x float>
ret <vscale x 2 x float> %5 ret <vscale x 2 x float> %5
} }

llvm/test/Transforms/InstCombine/scalable-trunc.ll

  • This file was moved from llvm/test/Transforms/InstCombine/AArch64/sve-trunc.ll.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -mtriple aarch64-linux-gnu -mattr=+sve -instcombine -S < %s 2>%t | FileCheck %s ; RUN: opt -instcombine -S < %s 2>%t | FileCheck %s
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t ; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it. ; If this check fails please read test/CodeGen/AArch64/README for instructions on how to resolve it.
; WARN-NOT: warning ; WARN-NOT: warning
define void @trunc_nxv2i64_to_nxv2i32(i32* %ptr, <vscale x 4 x i32> %v) { define void @trunc_nxv2i64_to_nxv2i32(i32* %ptr, <vscale x 4 x i32> %v) {
; CHECK-LABEL: @trunc_nxv2i64_to_nxv2i32( ; CHECK-LABEL: @trunc_nxv2i64_to_nxv2i32(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
Show All 19 Lines