This is an archive of the discontinued LLVM Phabricator instance.

Differential D98887

[clang-cl] make -ffile-compilation-dir a CoreOption.
ClosedPublic

Authored by zequanwu on Mar 18 2021, 12:30 PM.

Details

Reviewers
thakis
phosek
Commits
rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption.
Summary

Let clang-cl accepts -ffile-compilation-dir flag.

Diff Detail

Event Timeline

zequanwu created this revision.Mar 18 2021, 12:30 PM
Herald added subscribers: jansvoboda11, dang. · View Herald TranscriptMar 18 2021, 12:30 PM
zequanwu requested review of this revision.Mar 18 2021, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 12:30 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Mar 18 2021, 1:15 PM

LGTM

This revision is now accepted and ready to land.Mar 18 2021, 1:15 PM
This revision was landed with ongoing or failed builds.Mar 18 2021, 1:29 PM
Closed by commit rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu). · Explain Why
This revision was automatically updated to reflect the committed changes.
zequanwu added a commit: rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption..
Harbormaster completed remote builds in B94530: Diff 331655.Mar 18 2021, 2:09 PM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
1 line
test/
Driver/
1 line

Diff 331674

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,119 Lines • ▼ Show 20 Lines
def fdebug_compilation_dir : Separate<["-"], "fdebug-compilation-dir">, def fdebug_compilation_dir : Separate<["-"], "fdebug-compilation-dir">,
Group<f_Group>, Flags<[CC1Option, CC1AsOption, CoreOption]>, Group<f_Group>, Flags<[CC1Option, CC1AsOption, CoreOption]>,
Alias<fdebug_compilation_dir_EQ>; Alias<fdebug_compilation_dir_EQ>;
def fcoverage_compilation_dir_EQ : Joined<["-"], "fcoverage-compilation-dir=">, def fcoverage_compilation_dir_EQ : Joined<["-"], "fcoverage-compilation-dir=">,
Group<f_Group>, Flags<[CC1Option, CC1AsOption, CoreOption]>, Group<f_Group>, Flags<[CC1Option, CC1AsOption, CoreOption]>,
HelpText<"The compilation directory to embed in the coverage mapping.">, HelpText<"The compilation directory to embed in the coverage mapping.">,
MarshallingInfoString<CodeGenOpts<"CoverageCompilationDir">>; MarshallingInfoString<CodeGenOpts<"CoverageCompilationDir">>;
def ffile_compilation_dir_EQ : Joined<["-"], "ffile-compilation-dir=">, Group<f_Group>, def ffile_compilation_dir_EQ : Joined<["-"], "ffile-compilation-dir=">, Group<f_Group>,
Flags<[CoreOption]>,
HelpText<"The compilation directory to embed in the debug info and coverage mapping.">; HelpText<"The compilation directory to embed in the debug info and coverage mapping.">;
defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling",
CodeGenOpts<"DebugInfoForProfiling">, DefaultFalse, CodeGenOpts<"DebugInfoForProfiling">, DefaultFalse,
PosFlag<SetTrue, [CC1Option], "Emit extra debug info to make sample profile more accurate">, PosFlag<SetTrue, [CC1Option], "Emit extra debug info to make sample profile more accurate">,
NegFlag<SetFalse>>; NegFlag<SetFalse>>;
def fprofile_instr_generate : Flag<["-"], "fprofile-instr-generate">, def fprofile_instr_generate : Flag<["-"], "fprofile-instr-generate">,
Group<f_Group>, Flags<[CoreOption]>, Group<f_Group>, Flags<[CoreOption]>,
HelpText<"Generate instrumented code to collect execution counts into default.profraw file (overridden by '=' form of option or LLVM_PROFILE_FILE env var)">; HelpText<"Generate instrumented code to collect execution counts into default.profraw file (overridden by '=' form of option or LLVM_PROFILE_FILE env var)">;
▲ Show 20 Lines • Show All 4,947 Lines • Show Last 20 Lines

clang/test/Driver/cl-options.c

Show First 20 Lines • Show All 637 Lines • ▼ Show 20 Lines
// RUN: -fcolor-diagnostics \ // RUN: -fcolor-diagnostics \
// RUN: -fno-color-diagnostics \ // RUN: -fno-color-diagnostics \
// RUN: -fcoverage-mapping \ // RUN: -fcoverage-mapping \
// RUN: -fno-coverage-mapping \ // RUN: -fno-coverage-mapping \
// RUN: -fdiagnostics-color \ // RUN: -fdiagnostics-color \
// RUN: -fno-diagnostics-color \ // RUN: -fno-diagnostics-color \
// RUN: -fdebug-compilation-dir . \ // RUN: -fdebug-compilation-dir . \
// RUN: -fdebug-compilation-dir=. \ // RUN: -fdebug-compilation-dir=. \
// RUN: -ffile-compilation-dir=. \
// RUN: -fdiagnostics-parseable-fixits \ // RUN: -fdiagnostics-parseable-fixits \
// RUN: -fdiagnostics-absolute-paths \ // RUN: -fdiagnostics-absolute-paths \
// RUN: -ferror-limit=10 \ // RUN: -ferror-limit=10 \
// RUN: -fident \ // RUN: -fident \
// RUN: -fno-ident \ // RUN: -fno-ident \
// RUN: -fmsc-version=1800 \ // RUN: -fmsc-version=1800 \
// RUN: -fno-strict-aliasing \ // RUN: -fno-strict-aliasing \
// RUN: -fstrict-aliasing \ // RUN: -fstrict-aliasing \
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines