This is an archive of the discontinued LLVM Phabricator instance.

[libsupport] Silence a bogus valgrind warning.
ClosedPublic

Authored by lattner on Mar 17 2021, 5:38 PM.

Details

Summary

Valgrind is reporting this bogus warning because it doesn't model
pthread_sigmask fully accurately. This is a valgrind bug, but
silencing it has effectively no cost, so just do it.

==73662== Syscall param __pthread_sigmask(set) points to uninitialised byte(s)
==73662==    at 0x101E9D4C2: __pthread_sigmask (in /usr/lib/system/libsystem_kernel.dylib)
==73662==    by 0x101EFB5EA: pthread_sigmask (in /usr/lib/system/libsystem_pthread.dylib)
==73662==    by 0x1000D9F6D: llvm::sys::Process::SafelyCloseFileDescriptor(int) (in /Users/chrisl/Projects/circt/build/bin/firtool)
==73662==    by 0x100072795: llvm::ErrorOr<std::__1::unique_ptr<llvm::MemoryBuffer, std::__1::default_delete<llvm::MemoryBuffer> > > getFileAux<llvm::MemoryBuffer>(llvm::Twine const&, long long, unsigned long long, unsigned long long, bool, bool) (in /Users/chrisl/Projects/circt/build/bin/firtool)
==73662==    by 0x100072573: llvm::MemoryBuffer::getFileOrSTDIN(llvm::Twine const&, long long, bool) (in /Users/chrisl/Projects/circt/build/bin/firtool)
==73662==    by 0x100282C25: mlir::openInputFile(llvm::StringRef, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) (in /Users/chrisl/Projects/circt/build/bin

Diff Detail

Event Timeline

lattner created this revision.Mar 17 2021, 5:38 PM
lattner requested review of this revision.Mar 17 2021, 5:38 PM
lattner updated this revision to Diff 331425.Mar 17 2021, 5:45 PM

Trying to revise commit message

lattner updated this revision to Diff 331426.Mar 17 2021, 5:45 PM

trying to fix commit message

lattner updated this revision to Diff 331427.Mar 17 2021, 5:46 PM
lattner edited the summary of this revision. (Show Details)

Commit message; seriously

Harbormaster completed remote builds in B94361: Diff 331426.
lattner accepted this revision.Mar 18 2021, 9:09 AM

self-accepting as obvious :)

This revision is now accepted and ready to land.Mar 18 2021, 9:09 AM
This revision was landed with ongoing or failed builds.Mar 18 2021, 9:09 AM
This revision was automatically updated to reflect the committed changes.