This is an archive of the discontinued LLVM Phabricator instance.

Differential D98804

[AMDGPU] Remove unused template parameters of MUBUF_Real_AllAddr_vi
ClosedPublic

Authored by rampitec on Mar 17 2021, 12:02 PM.

Details

Reviewers
foad
Commits
rG3f37c2823072: [AMDGPU] Remove unused template parameters of MUBUF_Real_AllAddr_vi

Diff Detail

Event Timeline

rampitec created this revision.Mar 17 2021, 12:02 PM
Herald added subscribers: kerbowa, jfb, hiraditya and 8 others. · View Herald TranscriptMar 17 2021, 12:02 PM
rampitec requested review of this revision.Mar 17 2021, 12:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 12:02 PM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec mentioned this in D96469: [AMDGPU] Use single cache policy operand.Mar 17 2021, 12:02 PM
Harbormaster completed remote builds in B94295: Diff 331338.Mar 17 2021, 1:22 PM
foad accepted this revision.Mar 18 2021, 3:18 AM

Looks obvious, thanks!

This revision is now accepted and ready to land.Mar 18 2021, 3:18 AM
Closed by commit rG3f37c2823072: [AMDGPU] Remove unused template parameters of MUBUF_Real_AllAddr_vi (authored by rampitec). · Explain WhyMar 18 2021, 9:02 AM
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG3f37c2823072: [AMDGPU] Remove unused template parameters of MUBUF_Real_AllAddr_vi.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
4 lines

Diff 331338

llvm/lib/Target/AMDGPU/BUFInstructions.td

Show First 20 Lines • Show All 2,297 Lines • ▼ Show 20 Linesclass MUBUF_Real_gfx90a <bits<7> op, MUBUF_Pseudo ps> :
let Inst{55} = acc; let Inst{55} = acc;
} }
multiclass MUBUF_Real_vi_gfx90a<bits<7> op, MUBUF_Pseudo ps> { multiclass MUBUF_Real_vi_gfx90a<bits<7> op, MUBUF_Pseudo ps> {
def _vi : MUBUF_Real_vi<op, ps>; def _vi : MUBUF_Real_vi<op, ps>;
def _gfx90a : MUBUF_Real_gfx90a<op, ps>; def _gfx90a : MUBUF_Real_gfx90a<op, ps>;
} }
multiclass MUBUF_Real_AllAddr_vi<bits<7> op, bit isAtomic = 0, bit isAtomicRet = 0> { multiclass MUBUF_Real_AllAddr_vi<bits<7> op> {
defm _OFFSET : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET")>; defm _OFFSET : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET")>;
defm _OFFEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN")>; defm _OFFEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN")>;
defm _IDXEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN")>; defm _IDXEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN")>;
defm _BOTHEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN")>; defm _BOTHEN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN")>;
} }
multiclass MUBUF_Real_AllAddr_Lds_vi<bits<7> op> { multiclass MUBUF_Real_AllAddr_Lds_vi<bits<7> op> {
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
multiclass MUBUF_Real_AllAddr_gfx80<bits<7> op> { multiclass MUBUF_Real_AllAddr_gfx80<bits<7> op> {
def _OFFSET_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET")>; def _OFFSET_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET")>;
def _OFFEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN")>; def _OFFEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN")>;
def _IDXEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN")>; def _IDXEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN")>;
def _BOTHEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN")>; def _BOTHEN_gfx80 : MUBUF_Real_gfx80 <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN")>;
} }
multiclass MUBUF_Real_Atomic_vi<bits<7> op> : multiclass MUBUF_Real_Atomic_vi<bits<7> op> :
MUBUF_Real_AllAddr_vi<op, 1, 0> { MUBUF_Real_AllAddr_vi<op> {
defm _OFFSET_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET_RTN")>; defm _OFFSET_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFSET_RTN")>;
defm _OFFEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN_RTN")>; defm _OFFEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_OFFEN_RTN")>;
defm _IDXEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN_RTN")>; defm _IDXEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_IDXEN_RTN")>;
defm _BOTHEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN_RTN")>; defm _BOTHEN_RTN : MUBUF_Real_vi_gfx90a <op, !cast<MUBUF_Pseudo>(NAME#"_BOTHEN_RTN")>;
} }
defm BUFFER_LOAD_FORMAT_X : MUBUF_Real_AllAddr_Lds_vi <0x00>; defm BUFFER_LOAD_FORMAT_X : MUBUF_Real_AllAddr_Lds_vi <0x00>;
defm BUFFER_LOAD_FORMAT_XY : MUBUF_Real_AllAddr_vi <0x01>; defm BUFFER_LOAD_FORMAT_XY : MUBUF_Real_AllAddr_vi <0x01>;
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines