This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Use try_compile_only to check for __ARM_FP
ClosedPublic

Authored by mstorsjo on Mar 16 2021, 12:26 PM.

Details

Summary

This fixes detection when linking isn't supported (i.e. while building
builtins the first time).

Since 8368e4d54c459fe173d76277f17c632478e91add, after setting
CMAKE_TRY_COMPILE_TARGET_TYPE to STATIC_LIBRARY, this isn't strictly
needed, but is good for correctness anyway (and in case that commit
ends up reverted).

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 16 2021, 12:26 PM
mstorsjo requested review of this revision.Mar 16 2021, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 12:26 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Mar 16 2021, 12:30 PM
This revision is now accepted and ready to land.Mar 16 2021, 12:30 PM
This revision was landed with ongoing or failed builds.Mar 16 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.