This is an archive of the discontinued LLVM Phabricator instance.

Differential D98547

[compiler-rt] Use arm-specific builtins sources for arm/mingw builds
ClosedPublic

Authored by mstorsjo on Mar 12 2021, 12:09 PM.

Details

Reviewers
phosek
MaskRay
Commits
rGd374667257cf: [compiler-rt] Use arm-specific builtins sources for arm/mingw builds
Summary

Previously, that configuration only used the generic sources, in
addition to the couple specifically chosen arm/mingw files.

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 12 2021, 12:09 PM
Herald added subscribers: kristof.beyls, mgorny, dberris. · View Herald TranscriptMar 12 2021, 12:09 PM
mstorsjo requested review of this revision.Mar 12 2021, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 12:09 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
phosek accepted this revision.Mar 12 2021, 12:17 PM

LGTM

This revision is now accepted and ready to land.Mar 12 2021, 12:17 PM
Harbormaster completed remote builds in B93581: Diff 330342.Mar 12 2021, 2:34 PM
Closed by commit rGd374667257cf: [compiler-rt] Use arm-specific builtins sources for arm/mingw builds (authored by mstorsjo). · Explain WhyMar 13 2021, 12:22 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGd374667257cf: [compiler-rt] Use arm-specific builtins sources for arm/mingw builds.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
2 lines

Diff 330467

compiler-rt/lib/builtins/CMakeLists.txt

Show First 20 Lines • Show All 483 Lines • ▼ Show 20 Lines
if(MINGW) if(MINGW)
set(arm_SOURCES set(arm_SOURCES
arm/aeabi_idivmod.S arm/aeabi_idivmod.S
arm/aeabi_ldivmod.S arm/aeabi_ldivmod.S
arm/aeabi_uidivmod.S arm/aeabi_uidivmod.S
arm/aeabi_uldivmod.S arm/aeabi_uldivmod.S
arm/chkstk.S arm/chkstk.S
mingw_fixfloat.c mingw_fixfloat.c
${GENERIC_SOURCES} ${arm_SOURCES}
) )
elseif(NOT WIN32) elseif(NOT WIN32)
# TODO the EABI sources should only be added to EABI targets # TODO the EABI sources should only be added to EABI targets
set(arm_SOURCES set(arm_SOURCES
${arm_SOURCES} ${arm_SOURCES}
${arm_EABI_SOURCES} ${arm_EABI_SOURCES}
${arm_Thumb1_SOURCES} ${arm_Thumb1_SOURCES}
) )
▲ Show 20 Lines • Show All 241 Lines • Show Last 20 Lines