Page MenuHomePhabricator

[mlir] Make dispatchIndexOpFoldResult handle constant ops.
AbandonedPublic

Authored by hanchung on Mar 12 2021, 4:23 AM.

Details

Summary

This is useful when creating ops with createOrFold method. The method returns a
Value. If you store it in a SmallVector<OpFoldResult> vector, it is still a
ConstantOp if foldable, not an Attribute. Looking into the defining op will
simplify creating mixed operands cases.

Also fix a comment where uses the method.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > MLIR.Conversion/ShapeToStandard::shape-to-standard.mlir
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt --split-input-file --convert-shape-to-std --verify-diagnostics /mnt/disks/ssd0/agent/llvm-project/mlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Conversion/ShapeToStandard/shape-to-standard.mlir
100 msx64 debian > MLIR.Dialect/Linalg::promote.mlir
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/promote.mlir -linalg-promote-subviews | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/promote.mlir
20 msx64 debian > MLIR.Dialect/Linalg::tile-and-fuse-tensors.mlir
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile-and-fuse-tensors.mlir -test-linalg-greedy-fusion -split-input-file | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile-and-fuse-tensors.mlir
50 msx64 debian > MLIR.Dialect/Linalg::tile-and-pad-tensors.mlir
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile-and-pad-tensors.mlir -test-linalg-transform-patterns=test-tile-and-pad-pattern -canonicalize | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile-and-pad-tensors.mlir
30 msx64 debian > MLIR.Dialect/Standard::expand-ops.mlir
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt -std-expand /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Standard/expand-ops.mlir -split-input-file | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Standard/expand-ops.mlir
View Full Test Results (10 Failed)

Event Timeline

hanchung created this revision.Mar 12 2021, 4:23 AM
hanchung requested review of this revision.Mar 12 2021, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2021, 4:23 AM

It seems like I should fix bunch of tests...

hanchung planned changes to this revision.Mar 12 2021, 5:35 AM
hanchung abandoned this revision.Mon, Apr 12, 11:53 PM