Page MenuHomePhabricator

[scudo][standalone] Add shared library to makefile
ClosedPublic

Authored by cryptoad on Mar 11 2021, 2:44 PM.

Details

Summary

Since we are looking to remove the old Scudo, we have to have a .so for
parity purposes as some platforms use it.

I tested this on Fuchsia & Linux, not on Android though.

Diff Detail

Event Timeline

cryptoad created this revision.Mar 11 2021, 2:44 PM
cryptoad requested review of this revision.Mar 11 2021, 2:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 2:44 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
hctim added a comment.Mar 11 2021, 3:19 PM

LGTM w/ nit

compiler-rt/lib/scudo/standalone/CMakeLists.txt
134

Shouldn't this be -pthread to ldflags, not linking lpthread?

i.e.

append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)

cryptoad added inline comments.Mar 11 2021, 3:57 PM
compiler-rt/lib/scudo/standalone/CMakeLists.txt
134

Right, thanks! Not sure how it worked without the - either.

cryptoad updated this revision to Diff 330092.Mar 11 2021, 4:03 PM

Updating -pthread

hctim accepted this revision.Mar 11 2021, 4:21 PM
This revision is now accepted and ready to land.Mar 11 2021, 4:21 PM
This revision was landed with ongoing or failed builds.Mar 15 2021, 8:13 AM
This revision was automatically updated to reflect the committed changes.