Page MenuHomePhabricator

[llvm] Fix thinko in getVendorSignature(), where expected values of ECX and EDX were flipped for the AMD case.
ClosedPublic

Authored by oontvoo on Mar 9 2021, 11:44 PM.

Diff Detail

Event Timeline

oontvoo created this revision.Mar 9 2021, 11:44 PM
oontvoo requested review of this revision.Mar 9 2021, 11:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 11:44 PM
ppenzin accepted this revision.Mar 10 2021, 6:18 PM

Looks good in general, with one minor nit (inline).

llvm/lib/Support/Host.cpp
514–519

Minor nit: comments don't match the order of values.

This revision is now accepted and ready to land.Mar 10 2021, 6:18 PM
oontvoo updated this revision to Diff 329816.Mar 10 2021, 6:39 PM
oontvoo marked an inline comment as done.

updated diff

This revision was landed with ongoing or failed builds.Mar 10 2021, 6:39 PM
This revision was automatically updated to reflect the committed changes.