This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Simplify readability checks to not need ignoring* matchers
ClosedPublic

Authored by steveire on Mar 9 2021, 3:11 PM.

Diff Detail

Event Timeline

steveire requested review of this revision.Mar 9 2021, 3:11 PM
steveire created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 3:11 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
njames93 retitled this revision from Simplify readability checks to not need ignoring* matchers to [clang-tidy] Simplify readability checks to not need ignoring* matchers.Mar 10 2021, 5:21 AM

Please address the format issues.

clang-tools-extra/clang-tidy/readability/UniqueptrDeleteReleaseCheck.cpp
41–42

This allOf matcher only contains 1 sub matcher so is breaking the build.

Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 4:37 PM
steveire marked an inline comment as done.Mar 16 2021, 4:48 PM
njames93 accepted this revision.Mar 27 2021, 11:10 AM
njames93 added inline comments.
clang-tools-extra/clang-tidy/readability/DeletedDefaultCheck.cpp
31

Please rebase, this check has since been removed from clang-tidy.

This revision is now accepted and ready to land.Mar 27 2021, 11:10 AM