Page MenuHomePhabricator

[NFC] Remove duplicate isNoBuiltinFunc method
ClosedPublic

Authored by serge-sans-paille on Mar 8 2021, 5:50 AM.

Details

Summary

It's available both in CodeGenOptions and in LangOptions, and LangOptions
implementation is slightly better as it uses a StringRef instead of a char
pointer, so use it.

Diff Detail

Event Timeline

serge-sans-paille requested review of this revision.Mar 8 2021, 5:50 AM
mehdi_amini accepted this revision.Mar 8 2021, 9:28 PM

Seems like NFC? Can you tag the title with it?

This revision is now accepted and ready to land.Mar 8 2021, 9:28 PM

Well, it's not exactly a non functional change as it changes the API. A downstream user may need to update its code after this commit, right?

Well, it's not exactly a non functional change as it changes the API. A downstream user may need to update its code after this commit, right?

That's true for every refactoring: in general my rule of thumb is that if it isn't NFC there should be a test :)

serge-sans-paille retitled this revision from Remove duplicate isNoBuiltinFunc method to [NFC] Remove duplicate isNoBuiltinFunc method.Mar 10 2021, 12:05 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2021, 12:19 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

That was a very convincing argument :-) tag added.