Page MenuHomePhabricator

[CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes
ClosedPublic

Authored by tambre on Mar 6 2021, 1:48 AM.

Details

Summary

As reported in D93278 post-review symlinking requires privilege escalation on Windows.
Copying is functionally same, so fallback to it for systems that aren't Unix-like.
This is similar to the solution in AddLLVM.cmake.

Diff Detail

Event Timeline

tambre created this revision.Mar 6 2021, 1:48 AM
tambre requested review of this revision.Mar 6 2021, 1:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2021, 1:48 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
tambre added a comment.Mar 6 2021, 1:49 AM

@ikudrin Thanks for the report on D93278. Could you give this patch a try?

ikudrin accepted this revision.EditedMar 7 2021, 8:37 PM

The fix resolves the issue on my environment. Thank you for the quick response!

This revision is now accepted and ready to land.Mar 7 2021, 8:37 PM

The fix resolves the issue on my environment. Thank you for the quick response!

Thanks! I've filed a backport request for 12.0.