This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fix lone target exit data
ClosedPublic

Authored by jdenny on Mar 3 2021, 7:42 PM.

Details

Summary

Without this patch, an omp target exit data before the runtime is
initialized produces a runtime error. This patch fixes that by
changing __tgt_target_data_end_mapper to call CheckDeviceAndCtors
like other many other runtime routines.

Discussed at
https://lists.llvm.org/pipermail/openmp-dev/2021-March/003920.html.

Diff Detail

Event Timeline

jdenny created this revision.Mar 3 2021, 7:42 PM
jdenny requested review of this revision.Mar 3 2021, 7:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2021, 7:42 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
grokos accepted this revision.Mar 4 2021, 3:54 AM

LGTM

This revision is now accepted and ready to land.Mar 4 2021, 3:54 AM
This revision was landed with ongoing or failed builds.Mar 4 2021, 9:13 AM
This revision was automatically updated to reflect the committed changes.