This is an archive of the discontinued LLVM Phabricator instance.

Differential D97872

[clang] Don't assert in EmitAggregateCopy on trivial_abi types
ClosedPublic

Authored by aeubanks on Mar 3 2021, 9:59 AM.

Details

Reviewers
rsmith
ahatanak
rnk
Commits
rGc8227f06b335: [clang] Don't assert in EmitAggregateCopy on trivial_abi types
Summary

Fixes PR42961.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Mar 3 2021, 9:59 AM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2021, 9:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aeubanks added reviewers: rsmith, ahatanak.Mar 3 2021, 10:00 AM
jbroman added a subscriber: jbroman.Mar 3 2021, 10:44 AM
Harbormaster completed remote builds in B91850: Diff 327840.Mar 3 2021, 5:58 PM
rnk added a subscriber: rnk.Mar 8 2021, 3:57 PM
rnk added inline comments.
clang/test/CodeGenCXX/trivial_abi.cpp
267

Please check for the IR for the __invoke member of the lambda class. I think it's at least a bit interesting that we create two allocas, store to them, memcpy from one to the other, and then load out of the second.

aeubanks updated this revision to Diff 329165.Mar 8 2021, 5:03 PM

check IR

Harbormaster completed remote builds in B92762: Diff 329165.Mar 9 2021, 12:01 AM
rnk accepted this revision.Mar 9 2021, 11:58 AM

lgtm

This revision is now accepted and ready to land.Mar 9 2021, 11:58 AM
Closed by commit rGc8227f06b335: [clang] Don't assert in EmitAggregateCopy on trivial_abi types (authored by aeubanks). · Explain WhyMar 10 2021, 10:16 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGc8227f06b335: [clang] Don't assert in EmitAggregateCopy on trivial_abi types.

Revision Contents

PathSize
clang/
lib/
CodeGen/
2 lines
test/
CodeGenCXX/
18 lines

Diff 329165

clang/lib/CodeGen/CGExprAgg.cpp

Show First 20 Lines • Show All 2,050 Lines • ▼ Show 20 Linesvoid CodeGenFunction::EmitAggregateCopy(LValue Dest, LValue Src, QualType Ty,
if (getLangOpts().CPlusPlus) { if (getLangOpts().CPlusPlus) {
if (const RecordType *RT = Ty->getAs<RecordType>()) { if (const RecordType *RT = Ty->getAs<RecordType>()) {
CXXRecordDecl *Record = cast<CXXRecordDecl>(RT->getDecl()); CXXRecordDecl *Record = cast<CXXRecordDecl>(RT->getDecl());
assert((Record->hasTrivialCopyConstructor() || assert((Record->hasTrivialCopyConstructor() ||
Record->hasTrivialCopyAssignment() || Record->hasTrivialCopyAssignment() ||
Record->hasTrivialMoveConstructor() || Record->hasTrivialMoveConstructor() ||
Record->hasTrivialMoveAssignment() || Record->hasTrivialMoveAssignment() ||
Record->isUnion()) && Record->hasAttr<TrivialABIAttr>() || Record->isUnion()) &&
"Trying to aggregate-copy a type without a trivial copy/move " "Trying to aggregate-copy a type without a trivial copy/move "
"constructor or assignment operator"); "constructor or assignment operator");
// Ignore empty classes in C++. // Ignore empty classes in C++.
if (Record->isEmpty()) if (Record->isEmpty())
return; return;
} }
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines

clang/test/CodeGenCXX/trivial_abi.cpp

Show First 20 Lines • Show All 256 Lines • ▼ Show 20 Lines
// CHECK: resume { i8*, i32 } // CHECK: resume { i8*, i32 }
void calleeExceptionLarge(Large, Large); void calleeExceptionLarge(Large, Large);
void testExceptionLarge() { void testExceptionLarge() {
calleeExceptionLarge(Large(), Large()); calleeExceptionLarge(Large(), Large());
} }
// PR42961
rnkUnsubmitted
Not Done
ReplyInline Actions

Please check for the IR for the __invoke member of the lambda class. I think it's at least a bit interesting that we create two allocas, store to them, memcpy from one to the other, and then load out of the second.

rnk: Please check for the IR for the `__invoke` member of the lambda class. I think it's at least a…
// CHECK: define{{.*}} @"_ZN3$_08__invokeEv"()
// CHECK: %[[RETVAL:.*]] = alloca %[[STRUCT_SMALL]], align 8
// CHECK: %[[COERCE:.*]] = alloca %[[STRUCT_SMALL]], align 8
// CHECK: %[[CALL:.*]] = call{{.*}} @"_ZNK3$_0clEv"
// CHECK: %[[COERCEDIVE:.*]] = getelementptr{{.*}} %[[COERCE]]
// CHECK: %[[COERCEVALIP:.*]] = inttoptr{{.*}} %[[CALL]]
// CHECK: %[[RETVALP:.*]] = bitcast %[[STRUCT_SMALL]]* %[[RETVAL]]
// CHECK: %[[COERCEP:.*]] = bitcast %[[STRUCT_SMALL]]* %[[COERCE]]
// CHECK: call {{.*}}memcpy{{.*}} %[[RETVALP]]{{.*}} %[[COERCEP]]
// CHECK: %[[COERCEDIVE1:.*]] = getelementptr{{.*}} %[[RETVAL]]
// CHECK: %[[TMP:.*]] = load{{.*}} %[[COERCEDIVE1]]
// CHECK: %[[COERCEVALPI:.*]] = ptrtoint{{.*}} %[[TMP]]
// CHECK: ret{{.*}} %[[COERCEVALPI]]
Small (*fp)() = []() -> Small { return Small(); };