Page MenuHomePhabricator

[clang] Don't assert in EmitAggregateCopy on trivial_abi types
ClosedPublic

Authored by aeubanks on Mar 3 2021, 9:59 AM.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Mar 3 2021, 9:59 AM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2021, 9:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk added a subscriber: rnk.Mar 8 2021, 3:57 PM
rnk added inline comments.
clang/test/CodeGenCXX/trivial_abi.cpp
267

Please check for the IR for the __invoke member of the lambda class. I think it's at least a bit interesting that we create two allocas, store to them, memcpy from one to the other, and then load out of the second.

rnk accepted this revision.Mar 9 2021, 11:58 AM

lgtm

This revision is now accepted and ready to land.Mar 9 2021, 11:58 AM