Add noreturn attribute to non-returning functions

[zoecarver]

This LGTM. I think this matches __basic_string_common and __vector_base_common and friends.

[zoecarver]

Sorry, I didn't mean to accept this as libc++. Please wait for a second review.

[• Quuxplusone]

I did a grep for void __throw and verified that every other instance is attributed, except for:

• __throw_if_valueless in <variant>: this is good and intentional
• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

[hiraditya]

In D97308#2611794, @Quuxplusone wrote:

I did a grep for void __throw and verified that every other instance is attributed, except for:

• __throw_if_valueless in <variant>: this is good and intentional
• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

[• Quuxplusone]

In D97308#2615920, @hiraditya wrote:

In D97308#2611794, @Quuxplusone wrote:

• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

No, I meant this version: https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L6270

[hiraditya]

In D97308#2616596, @Quuxplusone wrote:

In D97308#2615920, @hiraditya wrote:

In D97308#2611794, @Quuxplusone wrote:

• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

No, I meant this version: https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L6270

The declaration already has the attribute so we don't need it here. https://github.com/llvm/llvm-project/blob/main/libcxx/include/stdexcept#L217

[• Quuxplusone]

Ah, sneaky. Anyway, ship it! :)

libcxx/include/__split_buffer

 
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 template <bool>
 class __split_buffer_common
 {
 protected:
-    void __throw_length_error() const;
-    void __throw_out_of_range() const;
+    _LIBCPP_NORETURN void __throw_length_error() const;
+    _LIBCPP_NORETURN void __throw_out_of_range() const;
 };
 
 template <class _Tp, class _Allocator = allocator<_Tp> >
 struct __split_buffer
     : private __split_buffer_common<true>
 {
 private:
     __split_buffer(const __split_buffer&);