This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Split EH MIR tests into two files
ClosedPublic

Authored by aheejin on Feb 21 2021, 8:08 PM.

Details

Summary

Currently exception.mir runs LateEHPrepare and CFGStackify, but some
tests I'm planning to add shouldn't be run with LateEHPrepare, because
it is convenient to only run CFGStackify when testing things like unwind
mismatches and it is easier to add tests that are in phase right before
CFGStackify. This splits existing exception.mir into two files;
cfg-stackify-eh.mir will only run CFGStackify. Note that
eh_label_tests tests both LateEHPrepare and CFGStackify, so it is
still in exception.mir. rethrow_arg_tests has been converted to the
post-LateEHPrepare form to be moved into cfg-stackify-eh.mir, like
removing CATCHRET and such, because it does not really test anything
in LateEHPrepare.

Diff Detail

Event Timeline

aheejin created this revision.Feb 21 2021, 8:08 PM
aheejin requested review of this revision.Feb 21 2021, 8:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2021, 8:08 PM
aheejin edited the summary of this revision. (Show Details)Feb 21 2021, 8:11 PM
dschuff accepted this revision.Feb 22 2021, 10:15 AM
dschuff added inline comments.
llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.mir
32

would it make sense for this to be a CHECK-LABEL (or for it to be bb.1: including the colon) to make the match more precise?

This revision is now accepted and ready to land.Feb 22 2021, 10:15 AM
aheejin updated this revision to Diff 325526.Feb 22 2021, 11:56 AM
aheejin marked an inline comment as done.

Added a colon after BB CHECK lines

aheejin updated this revision to Diff 325531.Feb 22 2021, 12:04 PM

Add missing (landing-pad)

llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.mir
32

Good idea. Added a colon to all BB CHECK lines.

This revision was landed with ongoing or failed builds.Feb 22 2021, 12:05 PM
This revision was automatically updated to reflect the committed changes.