Page MenuHomePhabricator

[ASTMatchers] Make nullPointerConstant usable at top-level
Needs ReviewPublic

Authored by steveire on Feb 21 2021, 10:22 AM.

Details

Diff Detail

Event Timeline

steveire requested review of this revision.Feb 21 2021, 10:22 AM
steveire created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2021, 10:22 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Won't this change require a regeneration of the documentation clang/docs/tools/dump_ast_matchers.py

steveire updated this revision to Diff 325398.Feb 22 2021, 1:59 AM

Update docs

Should we make nullPtrConstant() a top level mather? I feel like this change would actually throw users off.

Should we make nullPtrConstant() a top level mather? I feel like this change would actually throw users off.

This would make this matcher a "convenience" matcher. https://reviews.llvm.org/D97713

Currently it's something in between.