Page MenuHomePhabricator

[ASTMatchers] Add documentation for convenience matchers
Needs ReviewPublic

Authored by steveire on Mar 1 2021, 11:32 AM.

Details

Diff Detail

Event Timeline

steveire requested review of this revision.Mar 1 2021, 11:32 AM
steveire created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 11:32 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Thank you for this, I think it's helpful documentation! I have a few questions. Given that LibASTMatchersReference.html is a generated document, will these changes get overwritten by running dump_ast_matchers.py? Would it be possible to use some form of markup in ASTMatchers.h to generate this documentation so that it's easier to flag a particular matcher as being a "convenience" matcher? I expect we'll want to extend this list and it'd be nice if we didn't have some types of documentation that come from ASTMatchers.h and others that require manually editing the generated HTML file.