This is an archive of the discontinued LLVM Phabricator instance.

Differential D97093

[flang] Making Scope::FindCommonBlock a const member
ClosedPublic

Authored by Renaud-K on Feb 19 2021, 2:39 PM.

Details

Reviewers
schweitz
klausler
tskeith
PeteSteinfeld
Summary

Making Scope::FindCommonBlock a const member

Diff Detail

Event Timeline

Renaud-K requested review of this revision.Feb 19 2021, 2:39 PM
Renaud-K created this revision.
Renaud-K updated this revision to Diff 325095.Feb 19 2021, 2:50 PM

reated a full diff with "git show HEAD -U999999" instead of just "git show HEAD"

tskeith retitled this revision from Making Scope::FindCommonBlock a const member to [flang] Making Scope::FindCommonBlock a const member.Feb 19 2021, 2:50 PM
tskeith added a project: Restricted Project.
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 19 2021, 2:50 PM
Renaud-K added a reviewer: PeteSteinfeld.Feb 19 2021, 2:51 PM
klausler accepted this revision.Feb 19 2021, 2:57 PM

Looks okay to me.

This revision is now accepted and ready to land.Feb 19 2021, 2:57 PM
Renaud-K added a subscriber: flang-commits.Feb 19 2021, 2:59 PM
PeteSteinfeld accepted this revision.Feb 19 2021, 3:11 PM

All builds, tests, and looks good.

schweitz accepted this revision.Feb 19 2021, 5:51 PM
Renaud-K mentioned this in rG7d1397f7ad4b: Making FindCommonBlock a const member.Feb 22 2021, 10:10 AM
Renaud-K closed this revision.Feb 22 2021, 10:40 AM
Renaud-K removed a project: Restricted Project.Feb 22 2021, 1:05 PM
Renaud-K added a project: Restricted Project.

Revision Contents

PathSize
flang/
include/
flang/
Semantics/
2 lines
lib/
Semantics/
2 lines

Diff 325092

flang/include/flang/Semantics/scope.h

Context not available.
mapType &commonBlocks() { return commonBlocks_; } mapType &commonBlocks() { return commonBlocks_; }
const mapType &commonBlocks() const { return commonBlocks_; } const mapType &commonBlocks() const { return commonBlocks_; }
Symbol &MakeCommonBlock(const SourceName &); Symbol &MakeCommonBlock(const SourceName &);
Symbol *FindCommonBlock(const SourceName &); Symbol *FindCommonBlock(const SourceName &) const;
/// Make a Symbol but don't add it to the scope. /// Make a Symbol but don't add it to the scope.
template <typename D> template <typename D>
Context not available.

flang/lib/Semantics/scope.cpp

Context not available.
return symbol; return symbol;
} }
} }
Symbol *Scope::FindCommonBlock(const SourceName &name) { Symbol *Scope::FindCommonBlock(const SourceName &name) const {
const auto it{commonBlocks_.find(name)}; const auto it{commonBlocks_.find(name)};
return it != commonBlocks_.end() ? &*it->second : nullptr; return it != commonBlocks_.end() ? &*it->second : nullptr;
} }
Context not available.