This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Better support for rank-reducing subview / subtensor type inference.
ClosedPublic

Authored by nicolasvasilache on Feb 18 2021, 2:03 PM.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Feb 18 2021, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2021, 2:03 PM
ThomasRaoux added inline comments.Feb 18 2021, 2:09 PM
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
3050

nit; unintentional change?

mlir/lib/Dialect/StandardOps/IR/Ops.cpp
3448

Is this class unused now? We should delete it.

ThomasRaoux added inline comments.Feb 18 2021, 2:12 PM
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
3571

is this used or added for completness?

Address and rebase.

nicolasvasilache marked 3 inline comments as done.Feb 19 2021, 12:10 AM
nicolasvasilache added inline comments.
mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
3050

intentional actually, giving a bit of space to stuff that is logically separate.

mlir/lib/Dialect/StandardOps/IR/Ops.cpp
3448

I forgot we already had this, refactored to just use the rank-reducing type inference methods.

3571

Comlpeteness, added a test so now both :)

nicolasvasilache marked 3 inline comments as done.

Rebase.

ftynse accepted this revision.Feb 19 2021, 12:28 AM
ftynse added a subscriber: ftynse.
ftynse added inline comments.
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
2918

expected what?

This revision is now accepted and ready to land.Feb 19 2021, 12:28 AM
This revision was landed with ongoing or failed builds.Feb 19 2021, 12:35 AM
This revision was automatically updated to reflect the committed changes.