This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Correct gfx90c feature list
ClosedPublic

Authored by rampitec on Feb 18 2021, 12:33 PM.

Reviewers

Commits

rG5247a0d9e648: [AMDGPU] Correct gfx90c feature list

Summary

Looks like we have forced FeatureXNACK and forgot
FeatureMadMacF32Insts.

rampitec requested review of this revision.Feb 18 2021, 12:33 PM

Looks like we have forced FeatureXNACK and forgot FeatureMadMacF32Insts.

I think I have had it as a part of target id patch at some point, but dropped by Matts request. Thanks for adding it back.

LGTM

This revision is now accepted and ready to land.Feb 18 2021, 12:38 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Target/

AMDGPU/

2 lines

Show First 20 Lines • Show All 950 Lines • ▼ Show 20 Lines	def FeatureISAVersion9_0_A : FeatureSet<
FeatureSupportsSRAMECC,		FeatureSupportsSRAMECC,
FeaturePackedTID,		FeaturePackedTID,
FullRate64Ops]>;		FullRate64Ops]>;

def FeatureISAVersion9_0_C : FeatureSet<		def FeatureISAVersion9_0_C : FeatureSet<
[FeatureGFX9,		[FeatureGFX9,
FeatureMadMixInsts,		FeatureMadMixInsts,
FeatureLDSBankCount32,		FeatureLDSBankCount32,
FeatureXNACK,
FeatureDsSrc2Insts,		FeatureDsSrc2Insts,
FeatureExtendedImageInsts,		FeatureExtendedImageInsts,
		FeatureMadMacF32Insts,
FeatureImageGather4D16Bug]>;		FeatureImageGather4D16Bug]>;

// TODO: Organize more features into groups.		// TODO: Organize more features into groups.
def FeatureGroup {		def FeatureGroup {
// Bugs present on gfx10.1.		// Bugs present on gfx10.1.
list<SubtargetFeature> GFX10_1_Bugs = [		list<SubtargetFeature> GFX10_1_Bugs = [
FeatureVcmpxPermlaneHazard,		FeatureVcmpxPermlaneHazard,
FeatureVMEMtoScalarWriteHazard,		FeatureVMEMtoScalarWriteHazard,
▲ Show 20 Lines • Show All 450 Lines • Show Last 20 Lines