This is an archive of the discontinued LLVM Phabricator instance.

Differential D96911

[flang][fir][NFC] clang-tidy change
ClosedPublic

Authored by schweitz on Feb 17 2021, 3:30 PM.

Details

Reviewers
jeanPerier
svedanayagam
clementval
kiranchandramohan
Commits
rG0d4534237de3: [flang][fir][NFC] clang-tidy change

Diff Detail

Event Timeline

schweitz requested review of this revision.Feb 17 2021, 3:30 PM
schweitz created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 3:30 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kiranchandramohan accepted this revision.Feb 17 2021, 3:35 PM

LGTM.

This revision is now accepted and ready to land.Feb 17 2021, 3:35 PM
This revision was landed with ongoing or failed builds.Feb 17 2021, 3:41 PM
Closed by commit rG0d4534237de3: [flang][fir][NFC] clang-tidy change (authored by schweitz). · Explain Why
This revision was automatically updated to reflect the committed changes.
schweitz added a commit: rG0d4534237de3: [flang][fir][NFC] clang-tidy change.
Harbormaster completed remote builds in B89620: Diff 324442.Feb 17 2021, 4:39 PM

Revision Contents

PathSize
flang/
include/
flang/
Optimizer/
Dialect/
6 lines

Diff 324442

flang/include/flang/Optimizer/Dialect/FIRAttr.h

//===-- Optimizer/Dialect/FIRAttr.h -- FIR attributes -----------*- C++ -*-===// //===-- Optimizer/Dialect/FIRAttr.h -- FIR attributes -----------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Coding style: https://mlir.llvm.org/getting_started/DeveloperGuide/ // Coding style: https://mlir.llvm.org/getting_started/DeveloperGuide/
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef OPTIMIZER_DIALECT_FIRATTR_H #ifndef FORTRAN_OPTIMIZER_DIALECT_FIRATTR_H
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard]
not useful

Lint: Pre-merge checks: clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard] [[https…
#define OPTIMIZER_DIALECT_FIRATTR_H #define FORTRAN_OPTIMIZER_DIALECT_FIRATTR_H
#include "mlir/IR/BuiltinAttributes.h" #include "mlir/IR/BuiltinAttributes.h"
namespace mlir { namespace mlir {
class DialectAsmParser; class DialectAsmParser;
class DialectAsmPrinter; class DialectAsmPrinter;
} // namespace mlir } // namespace mlir
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Linesmlir::Attribute parseFirAttribute(FIROpsDialect *dialect,
mlir::DialectAsmParser &parser, mlir::DialectAsmParser &parser,
mlir::Type type); mlir::Type type);
void printFirAttribute(FIROpsDialect *dialect, mlir::Attribute attr, void printFirAttribute(FIROpsDialect *dialect, mlir::Attribute attr,
mlir::DialectAsmPrinter &p); mlir::DialectAsmPrinter &p);
} // namespace fir } // namespace fir
#endif // OPTIMIZER_DIALECT_FIRATTR_H #endif // FORTRAN_OPTIMIZER_DIALECT_FIRATTR_H