This is an archive of the discontinued LLVM Phabricator instance.

Differential D96803

EntryExitInstrumenter: Enable at all optimization levels (PR49143)
AbandonedPublic

Authored by zatrazz on Feb 16 2021, 11:15 AM.

Details

Reviewers
lenary
ostannard
aeubanks
Summary

It fixes PR49143 and allows re-enable the eeprof-1.c test from
test-suite (disabled by D96521).

Diff Detail

Event Timeline

zatrazz created this revision.Feb 16 2021, 11:15 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptFeb 16 2021, 11:15 AM
zatrazz requested review of this revision.Feb 16 2021, 11:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 16 2021, 11:15 AM
aeubanks added a comment.Feb 16 2021, 11:19 AM

why is this now a module pass?

Harbormaster completed remote builds in B89414: Diff 324059.Feb 16 2021, 11:49 AM
zatrazz added a comment.Feb 17 2021, 4:02 AM
In D96803#2566322, @aeubanks wrote:

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

aeubanks added a comment.Feb 17 2021, 12:44 PM
In D96803#2568179, @zatrazz wrote:
In D96803#2566322, @aeubanks wrote:

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

It's always good to make the pass as specific as possible (e.g. prefer a function pass rather than a module pass) so it doesn't have to worry about infra. For example, just iterating over functions doesn't skip declarations.

The whole point of isRequired() is to make the pass always run when it's added to the pipeline, so making it a module pass shouldn't be necessary with that line.

zatrazz added a comment.Feb 18 2021, 5:40 AM
In D96803#2569436, @aeubanks wrote:
In D96803#2568179, @zatrazz wrote:
In D96803#2566322, @aeubanks wrote:

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

It's always good to make the pass as specific as possible (e.g. prefer a function pass rather than a module pass) so it doesn't have to worry about infra. For example, just iterating over functions doesn't skip declarations.

I modeled it after AlwaysInlinerPass, since it seems that it was enabled at -O0 as well. To keep EntryExitInstrumenterPass a function pass and enable it with -O0 I think we will need a way to communicate to the pass manager that the pass should be run even with optnone, my understanding was that a ModulePass will the way to do it. Do we have a way to advertise that a function pass should be run regardless of ' optnone' ?

The whole point of isRequired() is to make the pass always run when it's added to the pipeline, so making it a module pass shouldn't be necessary with that line.

Indeed, I have added to fix a testcase but it does seem unrequired. I will remove it.

aeubanks added a comment.Feb 18 2021, 8:52 PM
In D96803#2571316, @zatrazz wrote:
In D96803#2569436, @aeubanks wrote:
In D96803#2568179, @zatrazz wrote:
In D96803#2566322, @aeubanks wrote:

why is this now a module pass?

Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better way to accomplish it? I noted also that createModuleToFunctionPassAdaptor basically creates a adaptor that applies the pass to all function on the module.

It's always good to make the pass as specific as possible (e.g. prefer a function pass rather than a module pass) so it doesn't have to worry about infra. For example, just iterating over functions doesn't skip declarations.

I modeled it after AlwaysInlinerPass, since it seems that it was enabled at -O0 as well.

AlwaysInlinerPass is a module pass because it does interprocedural changes. EntryExitInstrumenterPass works on one function at a time, which should be modeled as a function pass.

To keep EntryExitInstrumenterPass a function pass and enable it with -O0 I think we will need a way to communicate to the pass manager that the pass should be run even with optnone, my understanding was that a ModulePass will the way to do it. Do we have a way to advertise that a function pass should be run regardless of ' optnone' ?

That's what isRequired() is for...

Basically we need two changes. One is add isRequired() to EntryExitInstrumenterPass, the other is to run EntryExitInstrumenterPass under -O0 as well by removing the check in BackendUtil.cpp (or by changing it to CodeGenOpts.InstrumentFunctions || ... as you've done). Please keep the pass as a function pass.

zatrazz updated this revision to Diff 325004.Feb 19 2021, 9:04 AM
zatrazz retitled this revision from EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143) to EntryExitInstrumenter: Enable at all optimization levels (PR49143).
zatrazz edited the summary of this revision. (Show Details)

Updated patch based on previous comments.

aeubanks added a comment.Feb 22 2021, 9:13 AM

code looks good, just some test nits

llvm/test/Transforms/EntryExitInstrumenter/mcount.ll
1–4

I don't think it makes sense to add tests to llvm/test, there should be a clang test for this since the pass is added in clang. These tests aren't really testing the changed code.
Are there any existing tests for CodeGenOpts.InstrumentFunctions? We just need to make sure that the calls to the instrument functions exist for clang -O0.

aeubanks added a comment.Feb 26 2021, 8:28 PM

Alternatively: https://reviews.llvm.org/D97608

zatrazz abandoned this revision.Mar 1 2021, 6:33 AM

Revision Contents

PathSize
clang/
lib/
CodeGen/
7 lines
llvm/
include/
llvm/
Transforms/
Utils/
12 lines
lib/
Passes/
4 lines
Transforms/
Utils/
9 lines
test/
Transforms/
EntryExitInstrumenter/
2 lines
26 lines

Diff 324059

clang/lib/CodeGen/BackendUtil.cpp

//===--- BackendUtil.cpp - LLVM Backend Utilities -------------------------===// //===--- BackendUtil.cpp - LLVM Backend Utilities -------------------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 1,298 Lines • ▼ Show 20 Lines if (!CodeGenOpts.DisableLLVMPasses) {
if (!CodeGenOpts.ThinLTOIndexFile.empty()) if (!CodeGenOpts.ThinLTOIndexFile.empty())
PB.registerPipelineStartEPCallback( PB.registerPipelineStartEPCallback(
[](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) { [](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) {
MPM.addPass(LowerTypeTestsPass(/*ExportSummary=*/nullptr, MPM.addPass(LowerTypeTestsPass(/*ExportSummary=*/nullptr,
/*ImportSummary=*/nullptr, /*ImportSummary=*/nullptr,
/*DropTypeTests=*/true)); /*DropTypeTests=*/true));
}); });
if (Level != PassBuilder::OptimizationLevel::O0) { if (CodeGenOpts.InstrumentFunctions ||
CodeGenOpts.InstrumentFunctionsAfterInlining ||
CodeGenOpts.InstrumentFunctionEntryBare) {
PB.registerPipelineStartEPCallback( PB.registerPipelineStartEPCallback(
[](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) { [](ModulePassManager &MPM, PassBuilder::OptimizationLevel Level) {
MPM.addPass(createModuleToFunctionPassAdaptor( MPM.addPass(EntryExitInstrumenterPass(/*PostInlining=*/false));
EntryExitInstrumenterPass(/*PostInlining=*/false)));
}); });
} }
// Register callbacks to schedule sanitizer passes at the appropriate part // Register callbacks to schedule sanitizer passes at the appropriate part
// of the pipeline. // of the pipeline.
if (LangOpts.Sanitize.has(SanitizerKind::LocalBounds)) if (LangOpts.Sanitize.has(SanitizerKind::LocalBounds))
PB.registerScalarOptimizerLateEPCallback( PB.registerScalarOptimizerLateEPCallback(
[](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) { [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) {
▲ Show 20 Lines • Show All 301 Lines • Show Last 20 Lines

llvm/include/llvm/Transforms/Utils/EntryExitInstrumenter.h

//===- EntryExitInstrumenter.h - Function Entry/Exit Instrumentation ------===// //===- EntryExitInstrumenter.h - Function Entry/Exit Instrumentation ------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// EntryExitInstrumenter pass - Instrument function entry/exit with calls to // EntryExitInstrumenter pass - Instrument function entry/exit with calls to
// mcount(), @__cyg_profile_func_{enter,exit} and the like. There are two // mcount(), @__cyg_profile_func_{enter,exit} and the like. There are two
// variants, intended to run pre- and post-inlining, respectively. // variants, intended to run pre- and post-inlining, respectively.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H #ifndef LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H
#define LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H #define LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H
#include "llvm/IR/PassManager.h" #include "llvm/IR/PassManager.h"
namespace llvm { namespace llvm {
class Function; class EntryExitInstrumenterPass
struct EntryExitInstrumenterPass
: public PassInfoMixin<EntryExitInstrumenterPass> { : public PassInfoMixin<EntryExitInstrumenterPass> {
EntryExitInstrumenterPass(bool PostInlining) : PostInlining(PostInlining) {} bool PostInlining;
PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM); public:
EntryExitInstrumenterPass(bool PostInlining) : PostInlining(PostInlining) {}
bool PostInlining; PreservedAnalyses run(Module &M, ModuleAnalysisManager &);
static bool isRequired() { return true; }
}; };
} // namespace llvm } // namespace llvm
#endif // LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H #endif // LLVM_TRANSFORMS_UTILS_ENTRYEXITINSTRUMENTER_H

llvm/lib/Passes/PassRegistry.def

Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Lines
MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false)) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))
MODULE_PASS("msan-module", MemorySanitizerPass({})) MODULE_PASS("msan-module", MemorySanitizerPass({}))
MODULE_PASS("tsan-module", ThreadSanitizerPass()) MODULE_PASS("tsan-module", ThreadSanitizerPass())
MODULE_PASS("kasan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/true, false, true, false)) MODULE_PASS("kasan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/true, false, true, false))
MODULE_PASS("sancov-module", ModuleSanitizerCoveragePass()) MODULE_PASS("sancov-module", ModuleSanitizerCoveragePass())
MODULE_PASS("memprof-module", ModuleMemProfilerPass()) MODULE_PASS("memprof-module", ModuleMemProfilerPass())
MODULE_PASS("poison-checking", PoisonCheckingPass()) MODULE_PASS("poison-checking", PoisonCheckingPass())
MODULE_PASS("pseudo-probe-update", PseudoProbeUpdatePass()) MODULE_PASS("pseudo-probe-update", PseudoProbeUpdatePass())
MODULE_PASS("ee-instrument", EntryExitInstrumenterPass(/*PostInlining=*/false))
MODULE_PASS("post-inline-ee-instrument", EntryExitInstrumenterPass(/*PostInlining=*/true))
#undef MODULE_PASS #undef MODULE_PASS
#ifndef CGSCC_ANALYSIS #ifndef CGSCC_ANALYSIS
#define CGSCC_ANALYSIS(NAME, CREATE_PASS) #define CGSCC_ANALYSIS(NAME, CREATE_PASS)
#endif #endif
CGSCC_ANALYSIS("no-op-cgscc", NoOpCGSCCAnalysis()) CGSCC_ANALYSIS("no-op-cgscc", NoOpCGSCCAnalysis())
CGSCC_ANALYSIS("fam-proxy", FunctionAnalysisManagerCGSCCProxy()) CGSCC_ANALYSIS("fam-proxy", FunctionAnalysisManagerCGSCCProxy())
CGSCC_ANALYSIS("pass-instrumentation", PassInstrumentationAnalysis(PIC)) CGSCC_ANALYSIS("pass-instrumentation", PassInstrumentationAnalysis(PIC))
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
FUNCTION_PASS("correlated-propagation", CorrelatedValuePropagationPass()) FUNCTION_PASS("correlated-propagation", CorrelatedValuePropagationPass())
FUNCTION_PASS("dce", DCEPass()) FUNCTION_PASS("dce", DCEPass())
FUNCTION_PASS("div-rem-pairs", DivRemPairsPass()) FUNCTION_PASS("div-rem-pairs", DivRemPairsPass())
FUNCTION_PASS("dse", DSEPass()) FUNCTION_PASS("dse", DSEPass())
FUNCTION_PASS("dot-cfg", CFGPrinterPass()) FUNCTION_PASS("dot-cfg", CFGPrinterPass())
FUNCTION_PASS("dot-cfg-only", CFGOnlyPrinterPass()) FUNCTION_PASS("dot-cfg-only", CFGOnlyPrinterPass())
FUNCTION_PASS("early-cse", EarlyCSEPass(/*UseMemorySSA=*/false)) FUNCTION_PASS("early-cse", EarlyCSEPass(/*UseMemorySSA=*/false))
FUNCTION_PASS("early-cse-memssa", EarlyCSEPass(/*UseMemorySSA=*/true)) FUNCTION_PASS("early-cse-memssa", EarlyCSEPass(/*UseMemorySSA=*/true))
FUNCTION_PASS("ee-instrument", EntryExitInstrumenterPass(/*PostInlining=*/false))
FUNCTION_PASS("fix-irreducible", FixIrreduciblePass()) FUNCTION_PASS("fix-irreducible", FixIrreduciblePass())
FUNCTION_PASS("make-guards-explicit", MakeGuardsExplicitPass()) FUNCTION_PASS("make-guards-explicit", MakeGuardsExplicitPass())
FUNCTION_PASS("post-inline-ee-instrument", EntryExitInstrumenterPass(/*PostInlining=*/true))
FUNCTION_PASS("gvn-hoist", GVNHoistPass()) FUNCTION_PASS("gvn-hoist", GVNHoistPass())
FUNCTION_PASS("gvn-sink", GVNSinkPass()) FUNCTION_PASS("gvn-sink", GVNSinkPass())
FUNCTION_PASS("helloworld", HelloWorldPass()) FUNCTION_PASS("helloworld", HelloWorldPass())
FUNCTION_PASS("infer-address-spaces", InferAddressSpacesPass()) FUNCTION_PASS("infer-address-spaces", InferAddressSpacesPass())
FUNCTION_PASS("instcombine", InstCombinePass()) FUNCTION_PASS("instcombine", InstCombinePass())
FUNCTION_PASS("instcount", InstCountPass()) FUNCTION_PASS("instcount", InstCountPass())
FUNCTION_PASS("instsimplify", InstSimplifyPass()) FUNCTION_PASS("instsimplify", InstSimplifyPass())
FUNCTION_PASS("invalidate<all>", InvalidateAllAnalysesPass()) FUNCTION_PASS("invalidate<all>", InvalidateAllAnalysesPass())
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines

llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp

//===- EntryExitInstrumenter.cpp - Function Entry/Exit Instrumentation ----===// //===- EntryExitInstrumenter.cpp - Function Entry/Exit Instrumentation ----===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 162 Lines • ▼ Show 20 Lines
FunctionPass *llvm::createEntryExitInstrumenterPass() { FunctionPass *llvm::createEntryExitInstrumenterPass() {
return new EntryExitInstrumenter(); return new EntryExitInstrumenter();
} }
FunctionPass *llvm::createPostInlineEntryExitInstrumenterPass() { FunctionPass *llvm::createPostInlineEntryExitInstrumenterPass() {
return new PostInlineEntryExitInstrumenter(); return new PostInlineEntryExitInstrumenter();
} }
PreservedAnalyses PreservedAnalyses llvm::EntryExitInstrumenterPass::run(Module &M,
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-PreservedAnalyses llvm::EntryExitInstrumenterPass::run(Module &M,
-                                                       ModuleAnalysisManager &MAM) {
+PreservedAnalyses
+llvm::EntryExitInstrumenterPass::run(Module &M, ModuleAnalysisManager &MAM) {
Lint: Pre-merge checks: clang-format: please reformat the code ``` -PreservedAnalyses llvm::EntryExitInstrumenterPass…
llvm::EntryExitInstrumenterPass::run(Function &F, FunctionAnalysisManager &AM) { ModuleAnalysisManager &MAM) {
for (Function &F : M) {
runOnFunction(F, PostInlining); runOnFunction(F, PostInlining);
}
PreservedAnalyses PA; PreservedAnalyses PA;
PA.preserveSet<CFGAnalyses>(); PA.preserveSet<CFGAnalyses>();
return PA; return PA;
} }

llvm/test/Transforms/EntryExitInstrumenter/debug-info.ll

; RUN: opt -passes="function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument)" -S < %s | FileCheck %s ; RUN: opt -passes="ee-instrument,cgscc(inline),post-inline-ee-instrument" -S < %s | FileCheck %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
define i32 @f(i32 %x) #0 !dbg !7 { define i32 @f(i32 %x) #0 !dbg !7 {
entry: entry:
%x.addr = alloca i32, align 4 %x.addr = alloca i32, align 4
store i32 %x, i32* %x.addr, align 4 store i32 %x, i32* %x.addr, align 4
Show All 34 Lines

llvm/test/Transforms/EntryExitInstrumenter/mcount.ll

; RUN: opt -passes="function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument)" -S < %s | FileCheck %s ; RUN: opt --O0 --ee-instrument --inline --post-inline-ee-instrument -S < %s | FileCheck %s
; Check if the pass is enabbled on both -O0 and higher optimization levels
; RUN: opt --O2 --ee-instrument --post-inline-ee-instrument -S < %s | FileCheck --check-prefix=OPT %s
aeubanksUnsubmitted
Not Done
ReplyInline Actions

I don't think it makes sense to add tests to llvm/test, there should be a clang test for this since the pass is added in clang. These tests aren't really testing the changed code.
Are there any existing tests for CodeGenOpts.InstrumentFunctions? We just need to make sure that the calls to the instrument functions exist for clang -O0.

aeubanks: I don't think it makes sense to add tests to `llvm/test`, there should be a clang test for this…
; Running the passes twice should not result in more instrumentation. ; Running the passes twice should not result in more instrumentation.
; RUN: opt -passes="function(ee-instrument),function(ee-instrument),cgscc(inline),function(post-inline-ee-instrument),function(post-inline-ee-instrument)" -S < %s | FileCheck %s ; RUN: opt -passes="ee-instrument,ee-instrument,cgscc(inline),post-inline-ee-instrument,post-inline-ee-instrument" -S < %s | FileCheck %s
target datalayout = "E-m:e-i64:64-n32:64" target datalayout = "E-m:e-i64:64-n32:64"
target triple = "powerpc64le-unknown-linux" target triple = "powerpc64le-unknown-linux"
define void @leaf_function() #0 { define void @leaf_function() #0 {
entry: entry:
ret void ret void
; CHECK-LABEL: define void @leaf_function() ; CHECK-LABEL: define void @leaf_function()
; CHECK: entry: ; CHECK: entry:
; CHECK-NEXT: call void @mcount() ; CHECK-NEXT: call void @mcount()
; CHECK-NEXT: %0 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %0 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @leaf_function to i8*), i8* %0) ; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @leaf_function to i8*), i8* %0)
; CHECK-NEXT: %1 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %1 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @leaf_function to i8*), i8* %1) ; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @leaf_function to i8*), i8* %1)
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; OPT-LABEL: define void @leaf_function()
; OPT: entry:
; OPT-NEXT: call void @mcount()
; OPT-NEXT: %0 = call i8* @llvm.returnaddress(i32 0)
; OPT-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @leaf_function to i8*), i8* %0)
; OPT-NEXT: %1 = call i8* @llvm.returnaddress(i32 0)
; OPT-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @leaf_function to i8*), i8* %1)
; OPT-NEXT: ret void
} }
define void @root_function() #0 { define void @root_function() #0 {
entry: entry:
call void @leaf_function() call void @leaf_function()
ret void ret void
; CHECK-LABEL: define void @root_function() ; CHECK-LABEL: define void @root_function()
; CHECK: entry: ; CHECK: entry:
; CHECK-NEXT: call void @mcount() ; CHECK-NEXT: call void @mcount()
; CHECK-NEXT: %0 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %0 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @root_function to i8*), i8* %0) ; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @root_function to i8*), i8* %0)
; Entry and exit calls, inlined from @leaf_function() ; Entry and exit calls, inlined from @leaf_function()
; CHECK-NEXT: %1 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %1 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @leaf_function to i8*), i8* %1) ; CHECK-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @leaf_function to i8*), i8* %1)
; CHECK-NEXT: %2 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %2 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @leaf_function to i8*), i8* %2) ; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @leaf_function to i8*), i8* %2)
; CHECK-NEXT: %3 = call i8* @llvm.returnaddress(i32 0) ; CHECK-NEXT: %3 = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @root_function to i8*), i8* %3) ; CHECK-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @root_function to i8*), i8* %3)
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; OPT-LABEL: define void @root_function()
; OPT: entry:
; OPT-NEXT: call void @mcount()
; OPT-NEXT: %0 = call i8* @llvm.returnaddress(i32 0)
; OPT-NEXT: call void @__cyg_profile_func_enter(i8* bitcast (void ()* @root_function to i8*), i8* %0)
; OPT-NEXT: %1 = call i8* @llvm.returnaddress(i32 0)
; OPT-NEXT: call void @__cyg_profile_func_exit(i8* bitcast (void ()* @root_function to i8*), i8* %1)
; OPT-NEXT: ret void
} }
; The mcount function has many different names. ; The mcount function has many different names.
define void @f1() #1 { entry: ret void } define void @f1() #1 { entry: ret void }
; CHECK-LABEL: define void @f1 ; CHECK-LABEL: define void @f1
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines