Page MenuHomePhabricator

[OpenMP] Only use #pragma comment(lib, ...) in MSVC build configurations
ClosedPublic

Authored by mstorsjo on Feb 12 2021, 1:50 AM.

Details

Summary

MinGW build configurations don't support this pragma (unless compiling with clang, with -fms-extensions, and linking with lld), and at least clang warns about it.

This library does end up linked by the cmake files anyway (as long as the check works properly).

(I guess this could be made to be handled by cmake as well, by generalizing the existing code for mingw?)

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 12 2021, 1:50 AM
mstorsjo requested review of this revision.Feb 12 2021, 1:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sstefan1. · View Herald Transcript
This revision is now accepted and ready to land.Feb 12 2021, 8:36 AM
This revision was landed with ongoing or failed builds.Feb 12 2021, 11:56 AM
This revision was automatically updated to reflect the committed changes.