Page MenuHomePhabricator

[LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64
AbandonedPublic

Authored by omjavaid on Feb 10 2021, 3:55 PM.

Details

Summary

This patch builds on D96458 and add ability to pull in Aux Vector HWCAP information into NativeRegisterContextLinux_arm64.

In following up patches we will use this information to decide on whether we need to support certain Arm64 feature registers or not.

Diff Detail

Event Timeline

omjavaid created this revision.Feb 10 2021, 3:55 PM
DavidSpickett added inline comments.
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
104

Do I understand correctly that this will be filled in in a further patch? So right now it's only returning 0 because it's not hooked up yet.
For the sake of clean patches I'd rather it just returned 0, then put the rest of the work in the follow up.

omjavaid added inline comments.Feb 16 2021, 8:44 AM
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
104

Agreed. We can move implementation details to next inline patch where MTE/PAuth regs are being added.

omjavaid updated this revision to Diff 324021.Feb 16 2021, 8:44 AM
omjavaid updated this revision to Diff 325434.Feb 22 2021, 6:31 AM

Rebased after updates to parent.

DavidSpickett added inline comments.Feb 22 2021, 7:49 AM
lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
2038

Do we not get this from the protected GetAuxValue on NativeProcessELF?

omjavaid updated this revision to Diff 329235.Mar 9 2021, 12:26 AM

Rebased after changes in parent.

This revision is now accepted and ready to land.Mar 9 2021, 3:27 AM
labath requested changes to this revision.Mar 9 2021, 7:43 AM
labath added inline comments.
lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
2038

Indeed. We should not reimplement that here. I don't think there's any reason the NativeProcessELF function can't be public.

This revision now requires changes to proceed.Mar 9 2021, 7:43 AM
labath added inline comments.Mar 9 2021, 7:46 AM
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h
169

This should be a result instead of a by-ref argument.

omjavaid abandoned this revision.Mar 12 2021, 2:43 AM