Page MenuHomePhabricator

[mlir] make ModuleTranslation mapping fields private
ClosedPublic

Authored by ftynse on Feb 10 2021, 10:21 AM.

Details

Summary

ModuleTranslation contains multiple fields that keep track of the mappings
between various MLIR and LLVM IR components. The original ModuleTranslation
extension model was based on inheritance, with these fields being protected and
thus accessible in the ModuleTranslation and derived classes. The
inheritance-based model doesn't scale to translation of more than one derived
dialect and will be progressively replaced with a more flexible one based on
dialect interfaces and a translation state that is separate from
ModuleTranslation. This change prepares the replacement by making the mappings
private and providing public methods to access them.

Depends On D96436

Diff Detail

Event Timeline

ftynse created this revision.Feb 10 2021, 10:21 AM
ftynse requested review of this revision.Feb 10 2021, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2021, 10:22 AM
mehdi_amini accepted this revision.Feb 10 2021, 1:48 PM
This revision is now accepted and ready to land.Feb 10 2021, 1:48 PM
This revision was automatically updated to reflect the committed changes.