Page MenuHomePhabricator

[CodeGen] Basic block sections should take precedence over splitting.
ClosedPublic

Authored by snehasish on Feb 9 2021, 7:28 PM.

Details

Summary

The use of basic block sections should take precedence over the machine
function splitting pass. Since they use the same underlying mechanism
they are kept exclusive. Updated the tests to check that split machine
functions is overridden by all flavours of basic block sections.

Diff Detail

Event Timeline

snehasish created this revision.Feb 9 2021, 7:28 PM
snehasish requested review of this revision.Feb 9 2021, 7:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 7:28 PM
tmsriram added inline comments.Feb 9 2021, 7:46 PM
llvm/lib/CodeGen/TargetPassConfig.cpp
1190–1193

Could you add a TODO here that Machine Function Splitting and Basic Block Labels are in principle fine together but we have not addressed it yet?

snehasish updated this revision to Diff 322576.Feb 9 2021, 8:07 PM

Added FIXME to clarify that Labels and splitting can be enabled together but we don't support it yet.

snehasish marked an inline comment as done.Feb 9 2021, 8:07 PM
snehasish retitled this revision from [CodeGen] Basic block sections should take precendence over splitting. to [CodeGen] Basic block sections should take precedence over splitting..Feb 9 2021, 8:45 PM
tmsriram accepted this revision.Feb 9 2021, 8:49 PM
This revision is now accepted and ready to land.Feb 9 2021, 8:49 PM
This revision was landed with ongoing or failed builds.Feb 11 2021, 11:15 AM
This revision was automatically updated to reflect the committed changes.