Fix side-effect detection in LLVMIRIntrinsicGen.

[awpr]

Summary

Previously it reported an op had side-effects iff it declared that it
didn't have any side-effects. This had the undesirable result that
canonicalization would always delete any intrinsic calls that did memory
stores and returned void.

[mehdi_amini]

mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp

146

Functional?

return llvm::all_of(props, [] (const llvm::Record *r) {
   return (r->getName() != "IntrNoMem");
};

[awpr]

Change from loops with early retuns to llvm::any_of and llvm::none_of.

mlir/test/mlir-tblgen/llvm-intrinsics.td

 
 // CHECK-LABEL: def LLVM_ptrmask
 // CHECK: LLVM_IntrOp<"ptrmask
 // The result of this intrinsic result is overloadable.
 // CHECK: [0]
 // The second operand is overloadable, but the first operand needs to
 // match the result type.
 // CHECK: [1]
-// It has no additional traits.
-// CHECK: []
+// It has no side effects.
+// CHECK: [NoSideEffect]
 // It has a result.
 // CHECK: 1>
 // CHECK: Arguments<(ins LLVM_Type, LLVM_Type
 
 //---------------------------------------------------------------------------//
 
 // This checks that the ODS we produce can be consumed by MLIR tablegen. We only
 // make sure the entire process does not fail and produces some C++. The shape

mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp

for (const llvm::Record *r : results) {
              "expected operands to be of LLVM type");
     }
     return results.size();
   }
 
   /// Return true if the intrinsic may have side effects, i.e. does not have the
   /// `IntrNoMem` property.
   bool hasSideEffects() const {
-    auto props = record.getValueAsListOfDefs(fieldTraits);
-    for (const llvm::Record *r : props) {
-      if (r->getName() == "IntrNoMem")
-        return true;
-    }
-    return false;
+    return llvm::none_of(
+        record.getValueAsListOfDefs(fieldTraits),
+        [](const llvm::Record *r) { return r->getName() == "IntrNoMem"; });
   }
 
   /// Return true if the intrinsic is commutative, i.e. has the respective
   /// property.
   bool isCommutative() const {
-    auto props = record.getValueAsListOfDefs(fieldTraits);
-    for (const llvm::Record *r : props) {
-      if (r->getName() == "Commutative")
-        return true;
-    }
-    return false;
+    return llvm::any_of(
+        record.getValueAsListOfDefs(fieldTraits),
+        [](const llvm::Record *r) { return r->getName() == "Commutative"; });
   }
 
   IndicesTy getOverloadableOperandsIdxs() const {
     return getOverloadableTypeIdxs(record, fieldOperands);
   }
 
   IndicesTy getOverloadableResultsIdxs() const {
     return getOverloadableTypeIdxs(record, fieldResults);