Page MenuHomePhabricator

Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"
ClosedPublic

Authored by tstellar on Feb 9 2021, 1:50 PM.

Details

Summary

This reverts some of commit dbb01536f6f49fa428f170e34466072ef439b3e9.

The Reporter module was still being used by the ScanView.py module and deleting
it caused scan-view to fail. This commit adds back Reporter.py but removes the
code the references the AppleScript files which were removed in
dbb01536f6f49fa428f170e34466072ef439b3e9.

Diff Detail

Event Timeline

tstellar created this revision.Feb 9 2021, 1:50 PM
tstellar requested review of this revision.Feb 9 2021, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 1:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
NoQ accepted this revision.Feb 9 2021, 4:12 PM

Ok no problem!

I'll try to find time to clean this up properly.

This revision is now accepted and ready to land.Feb 9 2021, 4:12 PM
This revision was landed with ongoing or failed builds.Feb 11 2021, 7:11 PM
This revision was automatically updated to reflect the committed changes.

This commit is missing in release/12.x branch, so scan-view in recently released Clang 12.0.0 is broken.
Please backport this commit to release/12.x branch so that it is included at least in upcoming Clang 12.0.1.