Page MenuHomePhabricator

[Sanitizer] Fix sanitizer tests without reducing optimization levels
ClosedPublic

Authored by yln on Feb 9 2021, 10:43 AM.

Details

Summary

As discussed, these tests are compiled with optimization to mimic real
sanitizer usage [1].

Let's mark relevant functions with noinline so we can continue to
check against the stack traces in the report.

[1] https://reviews.llvm.org/D96198

This reverts commit 04af72c5423eb5ff7c0deba2d08cb46d583bb9d4.

Diff Detail

Event Timeline

yln created this revision.Feb 9 2021, 10:43 AM
yln requested review of this revision.Feb 9 2021, 10:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 10:43 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kcc accepted this revision.Feb 11 2021, 12:42 PM

LGTM, thanks for the better fix!

This revision is now accepted and ready to land.Feb 11 2021, 12:42 PM