This is an archive of the discontinued LLVM Phabricator instance.

Differential D96313

[SPARCv9] allow stw as alias for st
ClosedPublic

Authored by joerg on Feb 8 2021, 7:43 PM.

Details

Reviewers
LemonBoy
jrtc27
Commits
rG80836ee519eb: [SPARCv9] allow stw as alias for st
Summary

Strictly speaking, the architecture manual no longer uses the st
mnemonic, but that's a much more intrusive change for little gain.

Diff Detail

Event Timeline

joerg created this revision.Feb 8 2021, 7:43 PM
Herald added subscribers: fedor.sergeev, hiraditya, jyknight. · View Herald TranscriptFeb 8 2021, 7:43 PM
joerg requested review of this revision.Feb 8 2021, 7:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 7:43 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
LemonBoy accepted this revision.May 16 2021, 11:57 PM
LemonBoy added a reviewer: jrtc27.
LemonBoy added a subscriber: LemonBoy.

LGTM and matches GAS' behaviour.

This revision is now accepted and ready to land.May 16 2021, 11:57 PM
Herald added a subscriber: jeroen.dobbelaere. · View Herald TranscriptMay 16 2021, 11:57 PM
Closed by commit rG80836ee519eb: [SPARCv9] allow stw as alias for st (authored by joerg). · Explain WhyMay 20 2021, 6:29 AM
This revision was automatically updated to reflect the committed changes.
joerg added a commit: rG80836ee519eb: [SPARCv9] allow stw as alias for st.

Revision Contents

PathSize
llvm/
lib/
Target/
Sparc/
1 line
test/
MC/
Sparc/
3 lines

Diff 346708

llvm/lib/Target/Sparc/SparcInstrAliases.td

Show First 20 Lines • Show All 485 Lines • ▼ Show 20 Lines
def : MnemonicAlias<"stuba", "stba">; def : MnemonicAlias<"stuba", "stba">;
def : MnemonicAlias<"stsba", "stba">; def : MnemonicAlias<"stsba", "stba">;
def : MnemonicAlias<"stuh", "sth">; def : MnemonicAlias<"stuh", "sth">;
def : MnemonicAlias<"stsh", "sth">; def : MnemonicAlias<"stsh", "sth">;
def : MnemonicAlias<"stuha", "stha">; def : MnemonicAlias<"stuha", "stha">;
def : MnemonicAlias<"stsha", "stha">; def : MnemonicAlias<"stsha", "stha">;
def : MnemonicAlias<"stw", "st">, Requires<[HasV9]>;
def : MnemonicAlias<"lduw", "ld">, Requires<[HasV9]>; def : MnemonicAlias<"lduw", "ld">, Requires<[HasV9]>;
def : MnemonicAlias<"lduwa", "lda">, Requires<[HasV9]>; def : MnemonicAlias<"lduwa", "lda">, Requires<[HasV9]>;
def : MnemonicAlias<"return", "rett">, Requires<[HasV9]>; def : MnemonicAlias<"return", "rett">, Requires<[HasV9]>;
def : MnemonicAlias<"addc", "addx">, Requires<[HasV9]>; def : MnemonicAlias<"addc", "addx">, Requires<[HasV9]>;
def : MnemonicAlias<"addccc", "addxcc">, Requires<[HasV9]>; def : MnemonicAlias<"addccc", "addxcc">, Requires<[HasV9]>;
Show All 25 Lines

llvm/test/MC/Sparc/sparcv9-instructions.s

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s --check-prefix=V9
! V8: error: instruction requires a CPU feature not currently enabled ! V8: error: instruction requires a CPU feature not currently enabled
! V8-NEXT: rdpr %otherwin,%i5 ! V8-NEXT: rdpr %otherwin,%i5
! V9: rdpr %otherwin, %i5 ! encoding: [0xbb,0x53,0x40,0x00] ! V9: rdpr %otherwin, %i5 ! encoding: [0xbb,0x53,0x40,0x00]
rdpr %otherwin,%i5 rdpr %otherwin,%i5
! V8: error: instruction requires a CPU feature not currently enabled ! V8: error: instruction requires a CPU feature not currently enabled
! V8-NEXT: rdpr %wstate,%i5 ! V8-NEXT: rdpr %wstate,%i5
! V9: rdpr %wstate, %i5 ! encoding: [0xbb,0x53,0x80,0x00] ! V9: rdpr %wstate, %i5 ! encoding: [0xbb,0x53,0x80,0x00]
rdpr %wstate,%i5 rdpr %wstate,%i5
! V9: st %o1, [%o0] ! encoding: [0xd2,0x22,0x00,0x00]
stw %o1, [%o0]