This is an archive of the discontinued LLVM Phabricator instance.

[examples] Move llvm/examples/OCaml-Kaleidoscope/ to llvm-archive
ClosedPublic

Authored by xgupta on Feb 8 2021, 3:12 PM.

Details

Summary

It seems Ocaml-Kaleidoscope/ tutorial is not[[ https://github.com/llvm/llvm-project/commits/main/llvm/examples/OCaml-Kaleidoscope | updated from the last 10 years ]] (the last fix was on Fab 10, 2011). It does not validate itself with the tests. It seems no-one maintaining Ocaml. I tried to build it, Chapter 4,5,6,7 are not compiling because of an error In ExecutionEngine.

The error was:-

File "toplevel.ml", line 37, characters 25-53:
37 | let result = ExecutionEngine.run_function the_function [||]

^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error: Unbound module ExecutionEngine
Command exited with code 2.

Diff Detail

Event Timeline

xgupta created this revision.Feb 8 2021, 3:12 PM
xgupta requested review of this revision.Feb 8 2021, 3:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 3:12 PM
whitequark accepted this revision.Feb 8 2021, 3:49 PM

LGTM. I've been maintaining OCaml bindings for a while, but I never got the time to update the tutorial. (Ironically, that tutorial was what got me into LLVM *and* OCaml...) It is regrettable that it will be removed but I don't see another solution.

This revision is now accepted and ready to land.Feb 8 2021, 3:49 PM

OK, Thanks @whitequark for taking the time to review and comment. It is really unfortunate to remove such an awesome tutorial.

xgupta retitled this revision from [Draft] [examples] Move llvm/examples/OCaml-Kaleidoscope/ to llvm-archive to [examples] Move llvm/examples/OCaml-Kaleidoscope/ to llvm-archive.Feb 8 2021, 10:19 PM
geexie added a subscriber: geexie.Jan 12 2022, 5:41 AM