Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang-tidy] Simplify inaccurate erase check

Authored by steveire on Feb 5 2021, 6:44 AM.



The normalization of matchers means that this now works in all language

Diff Detail

Event Timeline

steveire created this revision.Feb 5 2021, 6:44 AM
steveire requested review of this revision.Feb 5 2021, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2021, 6:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
njames93 accepted this revision.Feb 12 2021, 8:24 AM

LG with nit.


This seems like a use case for the optionally matcher.

This revision is now accepted and ready to land.Feb 12 2021, 8:24 AM
This revision was landed with ongoing or failed builds.Feb 13 2021, 5:52 AM
This revision was automatically updated to reflect the committed changes.