Page MenuHomePhabricator

[clang-tidy] Simplify inaccurate erase check
ClosedPublic

Authored by steveire on Fri, Feb 5, 6:44 AM.

Details

Summary

The normalization of matchers means that this now works in all language
modes.

Diff Detail

Event Timeline

steveire created this revision.Fri, Feb 5, 6:44 AM
steveire requested review of this revision.Fri, Feb 5, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Feb 5, 6:44 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
njames93 accepted this revision.Fri, Feb 12, 8:24 AM

LG with nit.

clang-tools-extra/clang-tidy/bugprone/InaccurateEraseCheck.cpp
25–27

This seems like a use case for the optionally matcher.

This revision is now accepted and ready to land.Fri, Feb 12, 8:24 AM
This revision was landed with ongoing or failed builds.Sat, Feb 13, 5:52 AM
This revision was automatically updated to reflect the committed changes.