This is an archive of the discontinued LLVM Phabricator instance.

[🍒][libc++] Rename include/support to include/__support
ClosedPublic

Authored by ldionne on Feb 4 2021, 10:03 AM.

Details

Reviewers
tstellar
Group Reviewers
Restricted Project
Summary

We do ship those headers, so the directory name should not be something
that can potentially conflict with user-defined directories.

This is a cherry-pick of b51756819a85563ae063e98eeb3d6af8e44c8f64.

Diff Detail

Event Timeline

ldionne created this revision.Feb 4 2021, 10:03 AM
ldionne requested review of this revision.Feb 4 2021, 10:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 4 2021, 10:04 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision as: Restricted Project.Feb 4 2021, 10:05 AM

This is a cherry-pick from main to release/12.x. I think that is fairly important, because we now ship the support/ directory alongside the libc++ headers, and I am concerned that this could clash with user-provided support/ directories on users' header search paths.

tstellar accepted this revision.Feb 4 2021, 10:33 AM

Please go ahead and merge this to the release/12.x branch.

This revision is now accepted and ready to land.Feb 4 2021, 10:33 AM
libcxx/include/__support/openbsd/xlocale.h