This is an archive of the discontinued LLVM Phabricator instance.

Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables
ClosedPublic

Authored by dylanmckay on Feb 4 2021, 4:23 AM.

Details

Summary

I always forget this variable, and the distinction between
'LLVM_TARGET_ARCH', and this variable is only documented on the 'cross
compiling' page, which I never spot and always end up searching through
the codebase for.

This patch adds the variable to the Sphinx CMake documentation so that
it is easily findable in the official LLVM docs.

Diff Detail

Event Timeline

dylanmckay created this revision.Feb 4 2021, 4:23 AM
dylanmckay requested review of this revision.Feb 4 2021, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 4:23 AM
probinson accepted this revision.Feb 4 2021, 8:30 AM
probinson added a subscriber: probinson.

Seems reasonable, provided you correct the language to be about building a cross-compiler rather than actually cross-compiling.

llvm/docs/CMake.rst
352

If you are building a cross-compiler, ...

This revision is now accepted and ready to land.Feb 4 2021, 8:30 AM
dylanmckay added inline comments.Feb 4 2021, 10:54 PM
llvm/docs/CMake.rst
352

Very good point, I will correct.

This revision was landed with ongoing or failed builds.Dec 1 2021, 12:39 AM
This revision was automatically updated to reflect the committed changes.