[NFC][llvm-mca] Fix compiler warning

[pguo]

Summary

Fix clang compiler warning from -Wrange-loop-analysis.

[andreadb]

This is a duplicate of D95321.
No idea why it is taking so long for that other patch to go in.

[pguo]

Update commit message.

[pguo]

Update commit message.

[pguo]

@andreadb could you approve this again? I made minor changes to commit message, and it invalidates the approval status. Sorry to bother you again. Thanks.

[andreadb]

Not sure I understand why you would need an approval now. You have already committed this change.
See: https://reviews.llvm.org/rG91e7a17133324ac4beaf6ed45c170436c2d91c98

P.s.: I never approved it. However it is fine since it fixes a warning, and it is identical to D95321 which is already approved.

[pguo]

Thanks. I had a wrong impression that you approved this before, maybe I am confused by some flags from Harbormaster.

[andreadb]

No problem. Your change was good.
Thanks for fixing the warning.

llvm/tools/llvm-mca/Views/InstructionInfoView.cpp

void InstructionInfoView::printView(raw_ostream &OS) const {
   TempStream.flush();
   OS << Buffer;
 }
 
 void InstructionInfoView::collectData(
     MutableArrayRef<InstructionInfoViewData> IIVD) const {
   const llvm::MCSubtargetInfo &STI = getSubTargetInfo();
   const MCSchedModel &SM = STI.getSchedModel();
-  for (const auto &I : zip(getSource(), IIVD)) {
+  for (const auto I : zip(getSource(), IIVD)) {
     const MCInst &Inst = std::get<0>(I);
     InstructionInfoViewData &IIVDEntry = std::get<1>(I);
     const MCInstrDesc &MCDesc = MCII.get(Inst.getOpcode());
 
     // Obtain the scheduling class information from the instruction.
     unsigned SchedClassID = MCDesc.getSchedClass();
     unsigned CPUID = SM.getProcessorID();