Page MenuHomePhabricator

Add API for adding arguments to blocks
ClosedPublic

Authored by GeorgeLyon on Feb 3 2021, 12:31 PM.

Details

Summary

This just exposes a missing API

Diff Detail

Event Timeline

GeorgeLyon created this revision.Feb 3 2021, 12:31 PM
GeorgeLyon requested review of this revision.Feb 3 2021, 12:31 PM
GeorgeLyon edited the summary of this revision. (Show Details)Feb 3 2021, 12:32 PM
stellaraccident accepted this revision.Feb 3 2021, 12:47 PM

Thanks. I thought we had this but was obviously misremembering.

This revision is now accepted and ready to land.Feb 3 2021, 12:47 PM

Can you please extend the test to exercise this?

It looks like there are three tests failing currently on master for me, but they also fail for the previous commit (8d73bee4edc2)
[build] Failed Tests (3):
[build] MLIR :: mlir-cpu-runner/async-group.mlir
[build] MLIR :: mlir-cpu-runner/async-value.mlir
[build] MLIR :: mlir-cpu-runner/async.mlir

This revision was landed with ongoing or failed builds.Feb 3 2021, 1:15 PM
This revision was automatically updated to reflect the committed changes.