This is an archive of the discontinued LLVM Phabricator instance.

mlir/docs/LangRef.md
1174	Actually in terms of logical dimension, if the inner is i and outer it j, then this is correctly the `outer` and we should change the `outer` into `inner` 2 lines above.

This revision now requires changes to proceed.Feb 3 2021, 9:10 AM

Fix the docs according to review.

ergawy marked an inline comment as done.Feb 4 2021, 10:49 PM

Harbormaster completed remote builds in B88032: Diff 321661.Feb 4 2021, 11:31 PM

LG, thanks!

This revision is now accepted and ready to land.Feb 5 2021, 12:38 PM

Closed by commit rG86bde76b2905: [MLIR][LangRef doc] Fix a small typo. (authored by ergawy). · Explain WhyFeb 8 2021, 3:44 AM

This revision was automatically updated to reflect the committed changes.

ergawy added a commit: rG86bde76b2905: [MLIR][LangRef doc] Fix a small typo..

Revision Contents

Path

Size

mlir/

docs/

LangRef.md

2 lines

Diff 321661

mlir/docs/LangRef.md

	Show First 20 Lines • Show All 1,163 Lines • ▼ Show 20 Lines
	semi-affine maps. For example, `memref<42x16xf32, offset: 33, strides: [1, 64]>`			semi-affine maps. For example, `memref<42x16xf32, offset: 33, strides: [1, 64]>`
	specifies a non-contiguous memory region of `42` by `16` `f32` elements such			specifies a non-contiguous memory region of `42` by `16` `f32` elements such
	that:			that:

	1. the minimal size of the enclosing memory region must be `33 + 42 * 1 + 16 *			1. the minimal size of the enclosing memory region must be `33 + 42 * 1 + 16 *
	64 = 1066` elements;			64 = 1066` elements;
	2. the address calculation for accessing element `(i, j)` computes `33 + i +			2. the address calculation for accessing element `(i, j)` computes `33 + i +
	64 * j`			64 * j`
	3. the distance between two consecutive elements along the outer dimension is			3. the distance between two consecutive elements along the inner dimension is
	`1` element and the distance between two consecutive elements along the			`1` element and the distance between two consecutive elements along the
	outer dimension is `64` elements.			outer dimension is `64` elements.
				mehdi_aminiUnsubmitted Done Reply Inline Actions Actually in terms of logical dimension, if the inner is i and outer it j, then this is correctly the `outer` and we should change the `outer` into `inner` 2 lines above. mehdi_amini: Actually in terms of logical dimension, if the inner is i and outer it j, then this is…

	This corresponds to a column major view of the memory region and is internally			This corresponds to a column major view of the memory region and is internally
	represented as the type `memref<42x16xf32, (i, j) -> (33 + i + 64 * j)>`.			represented as the type `memref<42x16xf32, (i, j) -> (33 + i + 64 * j)>`.

	The specification of strides must not alias: given an n-D strided memref,			The specification of strides must not alias: given an n-D strided memref,
	indices `(i1, ..., in)` and `(j1, ..., jn)` may not refer to the same memory			indices `(i1, ..., in)` and `(j1, ..., jn)` may not refer to the same memory
	address unless `i1 == j1, ..., in == jn`.			address unless `i1 == j1, ..., in == jn`.

	▲ Show 20 Lines • Show All 484 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][LangRef doc] Fix a small typo.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 321661

mlir/docs/LangRef.md

[MLIR][LangRef doc] Fix a small typo.
ClosedPublic