Page MenuHomePhabricator

Fix MLIR Async Runtime DLL on Windows
ClosedPublic

Authored by mjp41 on Feb 3 2021, 2:24 AM.

Details

Summary

The AsyncRuntime declares prototypes for extern "C" functions inside a
namespace in the header, but not inside that namespace in the
definition. This causes Visual Studio to treat them as different
entities and thus the dllexport is ignored for the definitions.

Using the same namespace fixes this issue.

Secondly, this commit moves the dllexport to be consistent with the
JITs expectation.

This is an update to https://reviews.llvm.org/D95386 that fixes the compile issues in old versions of Visual studio.

Diff Detail

Event Timeline

mjp41 created this revision.Feb 3 2021, 2:24 AM
mjp41 requested review of this revision.Feb 3 2021, 2:25 AM
ezhulenev accepted this revision.Feb 3 2021, 2:40 AM
This revision is now accepted and ready to land.Feb 3 2021, 2:40 AM
This revision was automatically updated to reflect the committed changes.