This is an archive of the discontinued LLVM Phabricator instance.

[X86] Correct types in tablegen multiclasses found by D95874.
ClosedPublic

Authored by pengfei on Feb 2 2021, 10:10 PM.

Details

Summary

[X86] Correct types in tablegen multiclasses found by D95874.

Diff Detail

Event Timeline

pengfei created this revision.Feb 2 2021, 10:10 PM
pengfei requested review of this revision.Feb 2 2021, 10:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2021, 10:10 PM
craig.topper added inline comments.Feb 2 2021, 10:29 PM
llvm/lib/Target/X86/X86InstrAVX512.td
3314

Should we make immAllZerosV and immAllOnesV inherit from SDPatternOperator?

5303

Maybe we should jus use SDPatternOperator instead of PatFrags in these?

pengfei updated this revision to Diff 321019.Feb 3 2021, 12:00 AM
pengfei marked 2 inline comments as done.

Address Craig's comments.

Thanks Craig. That seems better.

This revision is now accepted and ready to land.Feb 3 2021, 12:02 AM
This revision was landed with ongoing or failed builds.Feb 3 2021, 12:26 AM
This revision was automatically updated to reflect the committed changes.