This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Fill out release notes for 12.x
ClosedPublic

Authored by int3 on Feb 2 2021, 3:18 PM.

Details

Reviewers
MaskRay
tstellar
smeenai
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

int3 created this revision.Feb 2 2021, 3:18 PM
int3 requested review of this revision.Feb 2 2021, 3:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2021, 3:18 PM
smeenai added a subscriber: smeenai.
smeenai added inline comments.
lld/docs/ReleaseNotes.rst
64–80

Nit: Mach-O (and I'd probably change it above as well)

int3 updated this revision to Diff 320941.Feb 2 2021, 3:54 PM

Mach-O

int3 marked an inline comment as done.Feb 2 2021, 3:55 PM
int3 added inline comments.
lld/docs/ReleaseNotes.rst
64–80

Haha I wrote it here w/o the hyphen because of the title above :p but yeah changed both

tschuett added inline comments.
lld/docs/ReleaseNotes.rst
76

How about listing them instead? Are there plans beyond ARM64?

int3 marked an inline comment as done.Feb 3 2021, 12:42 AM
int3 added inline comments.
lld/docs/ReleaseNotes.rst
76

yes, we'll likely want to support x86 and arm32 as well, since watchOS is 32-bit.

But "Support for architectures other than x86_64" sounds like it is secret, which other ISAs you want to support.

int3 updated this revision to Diff 321122.Feb 3 2021, 9:24 AM

list architectures explicitly

int3 added a comment.Feb 3 2021, 9:24 AM

Fair enough :)

smeenai accepted this revision.Feb 8 2021, 5:44 PM

LGTM

This revision is now accepted and ready to land.Feb 8 2021, 5:44 PM