Page MenuHomePhabricator

[OpenMP] Fixed an issue that taskwait doesn't work on detachable task
ClosedPublic

Authored by tianshilei1992 on Feb 1 2021, 10:03 AM.

Details

Summary

D77609 mistakenly changed the bebavior of task waiting on detachable task that a detachable task is not waited, based on https://lists.llvm.org/pipermail/openmp-dev/2021-February/003836.html. This patch fixed it. Thank Raúl for the report.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Feb 1 2021, 10:03 AM
tianshilei1992 requested review of this revision.Feb 1 2021, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 10:03 AM

Can we use the email reproducer as test?

Also, include a reference to the email in the commit message https://lists.llvm.org/pipermail/openmp-dev/2021-February/003836.html

tianshilei1992 edited the summary of this revision. (Show Details)Feb 1 2021, 10:07 AM

Added the reproducer

This revision is now accepted and ready to land.Feb 2 2021, 8:59 AM

Actually I'm pretty curious about how Windows tests passed...It is using pthread...

Make the test target independent