This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO] Tweaking inlining with pseudo probes.
ClosedPublic

Authored by hoy on Feb 1 2021, 9:08 AM.

Details

Summary

Fixing up a couple places where getCallSiteIdentifier is needed to support pseudo-probe-based callsites.

Also fixing an issue in the extbinary profile reader where the metadata section is not fully scanned based on the number of profiles loaded only for the current module.

Diff Detail

Event Timeline

hoy created this revision.Feb 1 2021, 9:08 AM
hoy requested review of this revision.Feb 1 2021, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 9:08 AM
hoy updated this revision to Diff 320497.Feb 1 2021, 9:09 AM

Updating D95791: [CSSPGO] Tweaks for inlining with pseudo probes.

hoy retitled this revision from [CSSPGO] Tweaks for inlining with pseudo probes. to [CSSPGO] Tweaking inlining with pseudo probes..Feb 1 2021, 9:10 AM
hoy edited the summary of this revision. (Show Details)
hoy added reviewers: wmi, davidxl, wenlei.
wmi accepted this revision.Feb 1 2021, 10:00 AM

LGTM.

This revision is now accepted and ready to land.Feb 1 2021, 10:00 AM
wenlei accepted this revision.Feb 1 2021, 1:06 PM

lgtm.

This revision was landed with ongoing or failed builds.Feb 1 2021, 1:57 PM
This revision was automatically updated to reflect the committed changes.